danders added a comment.
This seems to work fine, I also tested with only pageapp changes.
Imho I would prefer to separate the pageapp and KoMainWindow changes into
separate commits,
The pageapp changes should go into 3.2 branch followed by a swift release.
I don't think the KoMainWindow
anthonyfieroni added a comment.
Seems fine, i'll push pageapp/flake changes as part of this review in 3.2
branch and master, refactoring main window in separate commit master only.
REPOSITORY
R8 Calligra
REVISION DETAIL
https://phabricator.kde.org/D29542
To: anthonyfieroni, boemann, dan
Release needs to be tomorrow because of move to invent.kde.org
--
Cheers, Dag
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R8:2258d76ae064: Fix canvas event handling (authored by
anthonyfieroni).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.
leinir added a comment.
Incidentally, while this was committed before i could test it, i can confirm
that it works fine with Calligra Gemini
REPOSITORY
R8 Calligra
REVISION DETAIL
https://phabricator.kde.org/D29542
To: anthonyfieroni, boemann, danders, #calligra:_3.0
Cc: leinir, Calligr
anthonyfieroni added a comment.
Thank you, i should wait ship it, but just got Dag comment as it is.
REPOSITORY
R8 Calligra
REVISION DETAIL
https://phabricator.kde.org/D29542
To: anthonyfieroni, boemann, danders, #calligra:_3.0
Cc: leinir, Calligra-Devel-list, davidllewellynjones, dcalis
anthonyfieroni updated this revision to Diff 82815.
anthonyfieroni added reviewers: ndavis, VDG.
anthonyfieroni added a comment.
Rebase on master
REPOSITORY
R8 Calligra
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D15111?vs=41190&id=82815
REVISION DETAIL
https://phabricator.kd
