D29242: WIP: redesign sidebar

2020-04-28 Thread Carl Schwan
ognarb added a comment. There is a mockup here: T12837 this is really WIP I just created the diff because I asked someone to help me with a part of the code and I needed to show them the code. REPOSITORY R8 Calligra REVISION DETAIL https://phabricato

D29242: WIP: redesign sidebar

2020-04-28 Thread Camilla Boemann
boemann added a comment. Well you are definitely in the right class to make such changes. The thing is the current code was made to adopt to many different user wishes - so the user could choose What you are doing is to throw all that away - would it be impossible to have this new

D29242: WIP: redesign sidebar

2020-04-28 Thread Anthony Fieroni
anthonyfieroni added a comment. I don't know everyone wants tools to be above edit window. That's pretty old stile when resolution was 4:3 that's why they was arranged one above another. But i agree that it should be flexible to be horizontal or vertical as needed. INLINE COMMENTS > KoModeB

D29242: WIP: redesign sidebar

2020-04-28 Thread Carl Schwan
ognarb planned changes to this revision. ognarb added a comment. In D29242#658883 , @boemann wrote: > Well you are definitely in the right class to make such changes. > > The thing is the current code was made to adopt to many different user

D29242: WIP: redesign sidebar

2020-04-28 Thread Anthony Fieroni
anthonyfieroni added a comment. > The idea is to remove some of the configuration possibility: for example only allowing the KoModeBoxDocker to be a left or right sidebar. (putting at the top and bottom was completely broken anyway so I don't think many people did it). I think it can be

D25714: [WIP]: Port away from deprecated KHtml

2020-04-28 Thread Anthony Fieroni
anthonyfieroni added a comment. Is this still WIP, it looks good, can we proceed? REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D25714 To: ognarb, #calligra:_3.0 Cc: anthonyfieroni, danders, leinir, Calligra-Devel-list, davidllewellynjones, dcaliste, ognarb, cochise

D25714: [WIP]: Port away from deprecated KHtml

2020-04-28 Thread Anthony Fieroni
anthonyfieroni added a comment. Is this still WIP, it looks good, can we proceed? REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D25714 To: ognarb, #calligra:_3.0 Cc: anthonyfieroni, danders, leinir, Calligra-Devel-list, davidllewellynjones, dcaliste, ognarb, cochise