D24852: Remove list style from headings

2020-01-03 Thread Pekka Vuorela
pvuorela added a comment. Actually seems to now revert that one line as it was before commit fc7b878f206fb / https://bugs.kde.org/show_bug.cgi?id=306141 But the rationale sounds good to me, fixes the issue and no

D25423: Fill table cells with color for ODS and XLSX files

2020-01-03 Thread Pekka Vuorela
pvuorela added a comment. Not sure about all the details but two things look suspicious here: 1. Above this there's handling for transparent and now the handling isn't symmetric for background brush. 2. There's some handling on the file for KoXmlNs::draw / style-name & KoXmlNs::calligr

D25422: Handle custom-shapes to display text in ODP files

2020-01-03 Thread Pekka Vuorela
pvuorela added a comment. Don't know this shape stuff that well, but text shape plugin handling custom-shape feels suspicious. INLINE COMMENTS > TextShape.cpp:368 > +answer = loadOdfFrameElement(element, context); > +} > m_textShapeData->document()->setUndoRedoEnabled(true);