D25779: Ad a readOnly property to the QtQuick2 Document type which disables the loading of editor UI controls.

pvuorela accepted this revision. pvuorela added a comment. This revision is now accepted and ready to land. Seems to work and big impact indeed. Approving already. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D25779 To: denexter, pvuorela, leinir Cc: Calligra-Devel-

D25779: Ad a readOnly property to the QtQuick2 Document type which disables the loading of editor UI controls.

denexter updated this revision to Diff 72472. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25779?vs=71000&id=72472 REVISION DETAIL https://phabricator.kde.org/D25779 AFFECTED FILES components/Document.cpp components/Document.h components/impl/DocumentImpl.cpp components/imp

D25779: Ad a readOnly property to the QtQuick2 Document type which disables the loading of editor UI controls.

denexter marked an inline comment as done. denexter added inline comments. INLINE COMMENTS > pvuorela wrote in Document.cpp:57 > Looks like this is on top of Sailfish patched Calligra, upstream doesn't have > lastError. Could otherwise resolve that conflict myself, but the arc tool > doesn't se

D26328: Calculate and display proper number for headings started with lower level for DOC, DOCX and ODT.

mphilippov created this revision. mphilippov added reviewers: pvuorela, denexter, dcaliste, davidllewellynjones. mphilippov added a project: Calligra: 3.0. Herald added a subscriber: Calligra-Devel-list. mphilippov requested review of this revision. REVISION SUMMARY In previous version headings

D25715: Use RTF default color as default Qt format

davidllewellynjones added inline comments. INLINE COMMENTS > ColorTableDestination.cpp:44 > + handled = false; > qCDebug(lcRtf) << "unexpected control word in colortbl:" << > controlWord; > } It looks like there may be a distinction to be made between an empty control

D25779: Ad a readOnly property to the QtQuick2 Document type which disables the loading of editor UI controls.

This revision was automatically updated to reflect the committed changes. Closed by commit R8:bcda431ed438: Add a readOnly property to the QtQuick2 Document type which disables the… (authored by denexter, committed by pvuorela). REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabri

D25715: Use RTF default color as default Qt format

pvuorela added inline comments. INLINE COMMENTS > davidllewellynjones wrote in ColorTableDestination.cpp:44 > It looks like there may be a distinction to be made between an empty control > word and an unhandled control word. In the case of an unhandled control word, > clearing the colour seems

D25715: Use RTF default color as default Qt format

pvuorela added inline comments. INLINE COMMENTS > pvuorela wrote in ColorTableDestination.cpp:44 > Empty control word? Don't think that should be happening? Or well, the code might return such, but think the file in that case is broken and as such ok to complain about on debug. Also a bit separ

D25715: Use RTF default color as default Qt format

davidllewellynjones accepted this revision. davidllewellynjones added a comment. This revision is now accepted and ready to land. This looks good to me, and certainly gave better results for me using files with the 'auto' colour. INLINE COMMENTS > pvuorela wrote in ColorTableDestination.cpp:

D25715: Use RTF default color as default Qt format

This revision was automatically updated to reflect the committed changes. Closed by commit R8:959027525581: Use RTF default color as default Qt format (authored by pvuorela). REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25715?vs=70828&id=72487 REVISION DETAI