D26050: Fix build with poppler 82

2019-12-25 Thread Carl Schwan
ognarb added a comment. Doesn't compile for me with Poppler 81. So I created a small patch on top of your patch F7835712: poppler-81.patch REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D26050 To: tcanabrava, #calligra:_3.0

D26221: Use QQC2 Dialog

2019-12-25 Thread Carl Schwan
ognarb created this revision. Herald added a project: Calligra: 3.0. Herald added a subscriber: Calligra-Devel-list. ognarb requested review of this revision. REVISION SUMMARY Replace custom dialog with QQC2 Dialog TEST PLAN Screenshot comming REPOSITORY R8 Calligra BRANCH gemini-dialog

D26221: Use QQC2 Dialog

2019-12-25 Thread Carl Schwan
ognarb added reviewers: Calligra: 3.0, leinir. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D26221 To: ognarb, #calligra:_3.0, leinir Cc: Calligra-Devel-list, davidllewellynjones, dcaliste, ognarb, cochise, vandenoever

D26221: Use QQC2 Dialog

2019-12-25 Thread Carl Schwan
ognarb updated this revision to Diff 72174. ognarb added a comment. Update look REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26221?vs=72173&id=72174 BRANCH gemini-dialog REVISION DETAIL https://phabricator.kde.org/D26221 AFFECTED FILES gemini/qml/

D26221: Use QQC2 Dialog

2019-12-25 Thread Carl Schwan
ognarb edited the test plan for this revision. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D26221 To: ognarb, #calligra:_3.0, leinir Cc: Calligra-Devel-list, davidllewellynjones, dcaliste, ognarb, cochise, vandenoever

D26050: Fix build with poppler 82

2019-12-25 Thread Andreas Sturmlechner
asturmlechner added a comment. In D26050#578862 , @anthonyfieroni wrote: > Maybe we can drop 62, but not 72. If this is for master I don't see why we could keep anything pre-0.79. Distros already have to patch the hell out of 3.1.0 which

D26050: Fix build with poppler 82

2019-12-25 Thread Carl Schwan
ognarb added a comment. In D26050#582981 , @asturmlechner wrote: > In D26050#578862 , @anthonyfieroni wrote: > > > Maybe we can drop 62, but not 72. > > > If this is for master I don't see why

D26050: Fix build with poppler 82

2019-12-25 Thread Andreas Sturmlechner
asturmlechner added a comment. In D26050#583007 , @ognarb wrote: > In D26050#582981 , @asturmlechner wrote: > > > In D26050#578862 , @anthonyfieroni wrote: