D25034: Fix decoding of strings with wingdings/symbol characters in excel TxO records.

2019-11-08 Thread Pekka Vuorela
pvuorela added a reviewer: mkruisselbrink. pvuorela added a comment. But would those characters work without encoding adjustments if the used MS font was present? Not sure how it gets rendered now without the font, but if it's anything like the "J" exchange email smiley I'm not sure which is

D25034: Fix decoding of strings with wingdings/symbol characters in excel TxO records.

2019-11-08 Thread Andrew den Exter
denexter added a comment. The necessary font information is supplied independently, so if you have the font installed it does show the smiley. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D25034 To: denexter, pvuorela, mkruisselbrink Cc: Calligra-Devel-list, davidl

D25171: PDF Import: Add multipage support

2019-11-08 Thread Dag Andersen
danders updated this revision to Diff 69423. danders added a comment. Remove commented code REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25171?vs=69343&id=69423 BRANCH multipagepdf REVISION DETAIL https://phabricator.kde.org/D25171 AFFECTED FILES

D25171: PDF Import: Add multipage support

2019-11-08 Thread Dag Andersen
This revision was automatically updated to reflect the committed changes. Closed by commit R8:c81c23998e09: PDF Import: Add multipage support (authored by danders). REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25171?vs=69423&id=69424 REVISION DETAIL https:

D25214: Karbon image filter: Add multipage support

2019-11-08 Thread Dag Andersen
danders created this revision. danders added a reviewer: anthonyfieroni. Herald added a project: Calligra: 3.0. Herald added a subscriber: Calligra-Devel-list. danders requested review of this revision. REVISION SUMMARY Adds ability to select page in the options dialog TEST PLAN Export to png

D24852: Remove list style from headings

2019-11-08 Thread Aleksandr Komakhin
akomakhin updated this revision to Diff 69451. akomakhin edited the summary of this revision. REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24852?vs=68509&id=69451 REVISION DETAIL https://phabricator.kde.org/D24852 AFFECTED FILES libs/odf/KoOdfNumberDefin

D24852: Remove list style from headings

2019-11-08 Thread Camilla Boemann
boemann added a comment. This looks scarily generic What happens when the user via gui adds a numbered lists, and what is the impact in the other applications You are definitely on to something with formatSpecification, but maybe not setting is for all but only when loading headers

D24852: Remove list style from headings

2019-11-08 Thread Aleksandr Komakhin
akomakhin added a comment. But there is a simple statement in loadOdf function: if "num-format" is empty, then formatSpecification has a default value -- Numeric style. Isn't it strange, assuming all list styles numerical? REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.o

D24852: Remove list style from headings

2019-11-08 Thread Camilla Boemann
boemann added a comment. Not strange for a normal list - but yes for headings it sounds wrong - and I think this is where you need to make the changes. So if in load odf you are loading a heading and it doesn't specify numbering set it formatspecification to empty. But please make s