pvuorela added a comment.
Seems sensical for what I can tell. I'll do some test round and (likely)
approve later if no objections pop up.
REPOSITORY
R8 Calligra
REVISION DETAIL
https://phabricator.kde.org/D25032
To: denexter, pvuorela
Cc: Calligra-Devel-list, dcaliste, cochise, vandenoe
pvuorela accepted this revision.
pvuorela added a comment.
This revision is now accepted and ready to land.
Minor comment, but overall looks good to me.
INLINE COMMENTS
> excel.cpp:1421
> +if (ft2 == 0x0008) {
> +Q_ASSERT(ft2 == 0x0008); Q_UNUSED(ft2);
> +const
pvuorela added a comment.
Is there something in the spec encoding the microsoft fonts or just some kind
of practice? Seems a little scary just stripping bits.
If the main issue is the whole string disappearing, those text.clear() calls
below looks suspicious. Unicode string could contain
denexter added a comment.
There's nothing in the spec that I've found, there's a more detailed
explanation in the word parser
https://cgit.kde.org/calligra.git/tree/filters/words/msword-odf/wv2/src/parser9x.cpp#n513
but it still doesn't cite any sources. Removing the entire string is excessi
anthonyfieroni accepted this revision.
anthonyfieroni added inline comments.
This revision is now accepted and ready to land.
INLINE COMMENTS
> Pdf2OdgImport.cpp:130
> +globalParams = 0;
> +// m_chain->setOutputFile(QString());
> +return status;
Remove that line
REPOSITORY
R8 Call
Showstopper found, release delayed!
New release date: Thursday 2019-11-14.
dand...@get2net.dk skrev den 2019-10-29 08:50:
Hi,
release planned of calligraplan 3.2.0: Thursday, 2019-11-07.
String- and featurefreeze in effect from: Thursday, 2019-10-31.
Beta release (3.1.90) on friday, 2019-11-0
