This revision was automatically updated to reflect the committed changes.
Closed by commit R8:1b17db1a98ec: Better charset, unicode and image support for
RTF files (authored by pvuorela).
REPOSITORY
R8 Calligra
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D24943?vs=68972&id=69026
R
This revision was automatically updated to reflect the committed changes.
Closed by commit R8:e80856e8eb6a: Asign correct column width when importing XLS
file (authored by davidllewellynjones, committed by pvuorela).
REPOSITORY
R8 Calligra
CHANGES SINCE LAST UPDATE
https://phabricator.kde.or
anthonyfieroni added inline comments.
INLINE COMMENTS
> CMakeLists.txt:124-129
> +if (MSOOXML_MAX_SPREADSHEET_COLS)
> +add_definitions(
> -DMSOOXML_MAX_SPREADSHEET_COLS=${MSOOXML_MAX_SPREADSHEET_COLS} )
> +endif()
> +if (MSOOXML_MAX_SPREADSHEET_COLS)
> +add_definitions(
> -DMSOOXML_MAX_
anthonyfieroni added a comment.
I think `add` should be conditional.
REPOSITORY
R8 Calligra
REVISION DETAIL
https://phabricator.kde.org/D24852
To: akomakhin, pvuorela, #calligra:_3.0, boemann
Cc: anthonyfieroni, boemann, Calligra-Devel-list, dcaliste, cochise, vandenoever
Will you be making a stable branch and at what point will you do that?
Jonathan
On Tue, 29 Oct 2019 at 07:51, wrote:
> Hi,
> release planned of calligraplan 3.2.0: Thursday, 2019-11-07.
>
> String- and featurefreeze in effect from: Thursday, 2019-10-31.
>
> Beta release (3.1.90) on friday, 201
Jonathan Riddell skrev den 2019-10-30 11:44:
Will you be making a stable branch and at what point will you do that?
Ahh, forgot ;)
Releasing from trunk.
I'll create stable branch after release.
Thanks.
Jonathan
On Tue, 29 Oct 2019 at 07:51, wrote:
Hi,
release planned of calligraplan 3.2.0
davidllewellynjones added inline comments.
INLINE COMMENTS
> anthonyfieroni wrote in CMakeLists.txt:124-129
> Why 2 times?
That's a very good question; nicely noticed. I'll update the patch to remove
one.
REPOSITORY
R8 Calligra
REVISION DETAIL
https://phabricator.kde.org/D25008
To: david
davidllewellynjones updated this revision to Diff 69054.
davidllewellynjones added a comment.
Remove duplicated cmake definition.
REPOSITORY
R8 Calligra
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D25008?vs=68954&id=69054
REVISION DETAIL
https://phabricator.kde.org/D25008
AF
davidllewellynjones marked 2 inline comments as done.
davidllewellynjones added inline comments.
INLINE COMMENTS
> anthonyfieroni wrote in CMakeLists.txt:124-129
> Why 2 times?
Thanks again, I've removed the duplication now.
REPOSITORY
R8 Calligra
REVISION DETAIL
https://phabricator.kde.or