D18866: Use check_symbol_exists instead of check_function_exists

2019-02-10 Thread Heiko Becker
heikobecker updated this revision to Diff 51306. heikobecker added a comment. Replaced other check_function_exists invocations REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18866?vs=51220&id=51306 BRANCH master REVISION DETAIL https://phabricator.kde.

D18866: Use check_symbol_exists instead of check_function_exists

2019-02-10 Thread Heiko Becker
heikobecker added a comment. In D18866#408435 , @danders wrote: > What about the other ​check_function_exists, should they also be changed? Changed them, too. > Also, do you know when ​check_symbol_exists was introduced? > We still

D18866: Use check_symbol_exists instead of check_function_exists

2019-02-10 Thread Pino Toscano
pino added inline comments. INLINE COMMENTS > CMakeLists.txt:82 > > -check_function_exists( inflate ZLIB_HAS_INFLATE ) > +check_symbol_exists( inflate zlib. ZLIB_HAS_INFLATE ) > missing "h" in "zlib.h" REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D18866 To: heiko

D18866: Use check_symbol_exists instead of check_function_exists

2019-02-10 Thread Heiko Becker
heikobecker updated this revision to Diff 51307. heikobecker added a comment. Added missing "h". Thanks for noticing that. REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18866?vs=51306&id=51307 BRANCH master REVISION DETAIL https://phabricator.kde.org/

D18866: Use check_symbol_exists instead of check_function_exists

2019-02-10 Thread Heiko Becker
heikobecker marked an inline comment as done. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D18866 To: heikobecker Cc: pino, danders, Calligra-Devel-list, dcaliste, cochise, vandenoever