Re: Review Request 109071: Add a PRODUCTSET build config parameter (values ACTIVE, CREATIVE, DESKTOP, ALL)

2013-02-23 Thread Boudewijn Rempt
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109071/#review27915 --- Ship it! I'm really looking forward to this sanitization :-)

Re: Review Request 104021: Make dbus, knotify and phonon optional

2013-02-23 Thread Boudewijn Rempt
> On Feb. 19, 2012, 9:53 a.m., C. Boemann wrote: > > I'm only answering your question and not considering the patch at all. I > > think we should just use the qt and kde vars. I can't see any reason why we > > would disable those things if they are supported by upstream. > > Boudewijn Rempt w

Re: Review Request 108231: in Kpr import filter store all automatic styles from the master page in styles.xml

2013-02-23 Thread Boudewijn Rempt
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108231/#review27917 --- Thorsten, was this already committed? - Boudewijn Rempt On J

Re: Review Request 108353: Fix crash on empty style list in StyleManager dialog

2013-02-23 Thread Boudewijn Rempt
> On Jan. 14, 2013, 12:35 p.m., Friedrich W. H. Kossebau wrote: > > The patch works for me to fix the bug as reported, so ship it, thanks. > > > > But... it opened the path to the next crash: > > selecting the char tab like in the bug reported, and then clicking the > > "New" button yields anot

Re: Review Request 108651: Nicer appearance of image after cropping.

2013-02-23 Thread Boudewijn Rempt
> On Jan. 29, 2013, 8:36 a.m., Dmitry Kazakov wrote: > > libs/widgets/KoZoomController.h, line 88 > > > > > > Probably, some other name without 'set' prefix would be better? One > > might thing this "setter"-metho

Re: Review Request 109113: Set focus on Create Button at start-up in Krita

2013-02-23 Thread Somsubhra Bairi
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109113/ --- (Updated Feb. 23, 2013, 4:15 p.m.) Review request for Calligra and Boudewi

Get ready for GSoC! KDE++ aka Polishing Existing Things

2013-02-23 Thread Lydia Pintscher
Heya folks :) It's time to prepare for Google Summer of Code 2013. In order to have a kick-ass application we need to have a great ideas page. Please help fill this page soon: http://community.kde.org/GSoC/2013/Ideas Students are already looking around for ideas so try not to wait too long please.

submit proposals for Akademy talks

2013-02-23 Thread Lydia Pintscher
Heya folks :) Akademy is getting closer and it is time to submit proposals for talks. This is your chance to present your work and ideas to the KDE community in person. The call for papers is here: http://akademy2013.kde.org/cfp It has all the details. I'm sure there's something interesting you co

Re: Review Request 109113: Set focus on Create Button at start-up in Krita

2013-02-23 Thread Boudewijn Rempt
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109113/#review27934 --- Ship it! Yes, works perfectly! Do you have commit access, or s

Re: Review Request 109113: Set focus on Create Button at start-up in Krita

2013-02-23 Thread Somsubhra Bairi
> On Feb. 23, 2013, 5:07 p.m., Boudewijn Rempt wrote: > > Yes, works perfectly! Do you have commit access, or shall I commit it? No, I don't have commit access. - Somsubhra --- This is an automatically generated e-mail. To reply, visit:

Re: Check for Qt classes that should not be used

2013-02-23 Thread Inge Wallin
On Saturday, February 23, 2013 01:20:46 Sven Langkamp wrote: > On Wed, Feb 20, 2013 at 12:07 PM, Jean-Nicolas Artaud > > wrote: > > 2013/2/20 Sven Langkamp > > > >> On Wed, Feb 20, 2013 at 9:35 AM, Inge Wallin wrote: > >> > As you may have noticed, I have taken some interest in EBN, the KDE >

Re: Review Request 109113: Set focus on Create Button at start-up in Krita

2013-02-23 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109113/#review27939 --- This review has been submitted with commit 792fc0803bba4e9077c

Re: Review Request 109082: Separate files for the app into own subdir "app/" for Stage and Words

2013-02-23 Thread Yue Liu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109082/#review27943 --- Any directory change is fine with Mac. Only cmake configuration

Re: Review Request 109071: Add a PRODUCTSET build config parameter (values ACTIVE, CREATIVE, DESKTOP, ALL)

2013-02-23 Thread Friedrich W. H. Kossebau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109071/ --- (Updated Feb. 24, 2013, 12:11 a.m.) Review request for Calligra. Changes

Review Request 109123: Set the freehand tool curve exactness default value to 1

2013-02-23 Thread Somsubhra Bairi
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109123/ --- Review request for Calligra and Boudewijn Rempt. Description --- Set