Re: Review Request 108444: Fix cash on creating new character style

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108444/ --- (Updated Jan. 18, 2013, 2:09 p.m.) Review request for Calligra and Friedri

Re: Review Request 108420: "Fit Text Width" zoom mode

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108420/#review25754 --- libs/widgets/KoZoomController.cpp

Review Request 108475: fix broken check for small diff in KoTextLayoutArea::layoutBlock(...)

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108475/ --- Review request for Calligra and C. Boemann. Description --- MS compil

Review Request 108476: fix strange code in PictureShape::_Private::generateOutline(...)

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108476/ --- Review request for Calligra and C. Boemann. Description --- MSVC comp

Re: Review Request 108444: Fix cash on creating new character style

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108444/#review25756 --- Ship it! Works for me now, no crashes and very strange behavio

Re: Review Request 108379: Fix merging style to caret

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108379/#review25758 --- This review has been submitted with commit 415bb03d54671f7e03b

Re: Review Request 108444: Fix cash on creating new character style

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108444/#review25759 --- This review has been submitted with commit eb2696c33941d0c62cd

Re: Review Request 108475: fix broken check for small diff in KoTextLayoutArea::layoutBlock(...)

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108475/#review25762 --- Ship it! Another case when supporting MSVC improves code quali

Review Request 108478: fix for a broken algorithm type comparison in MsooXmlDiagramReader_p.cpp

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108478/ --- Review request for Calligra and Sebastian Sauer. Description --- Saw

Re: Review Request 107717: Move ElapsedTime class to a private header that wont be installed

> On Dec. 14, 2012, 4:33 p.m., Marijn Kruisselbrink wrote: > > LGTM > > Philip Hoof wrote: > When commtting please use this patch, to avoid conflict on my local > branch, using git am (not patch -p1 < etc.diff): > > > http://mail.kde.org/pipermail/calligra-devel/attachments/201212

Re: Review Request 108475: fix broken check for small diff in KoTextLayoutArea::layoutBlock(...)

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108475/#review25767 --- Ship it! yes you are right - good catch and please backport to

Review Request 108479: Change Tracker in KoTextWriter and KoTextLoader removal

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108479/ --- Review request for Calligra. Description --- This strips out the chan

Re: Review Request 108476: fix strange code in PictureShape::_Private::generateOutline(...)

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108476/#review25768 --- Ship it! i believe you are right - please backport too - C. B

Re: Review Request 108476: fix strange code in PictureShape::_Private::generateOutline(...)

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108476/#review25769 --- Ship it! i believe you are right - please backport too - C. B

Re: Review Request 108479: Change Tracker in KoTextWriter and KoTextLoader removal

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108479/#review25770 --- Hi I've started to review but it seems there is a recurring the

Re: Review Request 108479: Change Tracker in KoTextWriter and KoTextLoader removal

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108479/ --- (Updated Jan. 19, 2013, 1:48 a.m.) Review request for Calligra. Changes

Re: Review Request 108420: "Fit Text Width" zoom mode

> On Jan. 18, 2013, 3:07 p.m., Dmitry Kazakov wrote: > > libs/widgets/KoZoomController.cpp, lines 276-278 > > > > > > I have such a feeling that this explicit signal emission can be > > removed, because all the c

Re: Review Request 108420: "Fit Text Width" zoom mode

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108420/#review25773 --- Ship it! Ship It! - Dmitry Kazakov On Jan. 15, 2013, 5:04 a

Re: Review Request 108420: "Fit Text Width" zoom mode

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108420/#review25774 --- This review has been submitted with commit 8958e264695d65b33aa

Re: Review Request 108479: Change Tracker in KoTextWriter and KoTextLoader removal

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108479/ --- (Updated Jan. 19, 2013, 4:49 a.m.) Review request for Calligra. Changes

Re: Review Request 108459: Refactor in KoText

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108459/ --- (Updated Jan. 19, 2013, 6:58 a.m.) Review request for Calligra and Thorste

Re: Review Request 108459: Refactor in KoText

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108459/ --- (Updated Jan. 19, 2013, 7:20 a.m.) Review request for Calligra and Thorste