Re: Review Request: Better integration of pencil tool into Krita

2012-12-29 Thread Boudewijn Rempt
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107996/#review24164 --- Ship it! Cool work! - Boudewijn Rempt On Dec. 29, 2012, 2:2

Re: Review Request: Better integration of pencil tool into Krita

2012-12-29 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107996/#review24169 --- This review has been submitted with commit a8b3f36b39bc486fe5b

RR for removing 5 unused files from filters/sheets/csv

2012-12-29 Thread Friedrich W. H. Kossebau
Hi, grepping for Q3 I found that these 5 files are no longer used. Seems it was forgotten to remove them in the commit 038515dfc447d0a3e2a6cfdd872efc67fcc1076d Filters CSV Import. Switch to the shared KoCsvImportDialog. Anyone objecting to remove these files?

Re: Review Request: Make the epub filter handle math formulas

2012-12-29 Thread Inge Wallin
> On Dec. 28, 2012, 2:45 p.m., C. Boemann wrote: > > there is a few places where you have: > > > > if () > > { > > > > and one place where there is no {} after if > > > > other than that I've not looked yet - I assume you want moji to review The if () { construct is only used where the tes

Re: Review Request: Make the epub filter handle math formulas

2012-12-29 Thread Inge Wallin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107969/ --- (Updated Dec. 30, 2012, 4:44 a.m.) Review request for Calligra. Changes

Re: Review Request: Make the epub filter handle math formulas

2012-12-29 Thread C. Boemann
> On Dec. 28, 2012, 2:45 p.m., C. Boemann wrote: > > there is a few places where you have: > > > > if () > > { > > > > and one place where there is no {} after if > > > > other than that I've not looked yet - I assume you want moji to review > > Inge Wallin wrote: > The > > if (

Review Request: Make a real dynamic library out of kdgantt

2012-12-29 Thread Inge Wallin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108019/ --- Review request for Calligra and Stuart Dickson. Description --- This

Re: Review Request: Make a real dynamic library out of kdgantt

2012-12-29 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108019/#review24216 --- I think the code looks nice enough, so stuart are free to appro