Re: Review Request: Adds d-pointers to Kexi classes in kexi/core

2012-12-10 Thread Andrey Inishev
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107515/ --- (Updated Dec. 10, 2012, 9:46 a.m.) Review request for Calligra and Jarosła

Re: Review Request: [GCI] Adding d-pointers (part #1)

2012-12-10 Thread Shou Ya
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107610/ --- (Updated Dec. 10, 2012, 1:19 p.m.) Review request for Calligra and Jarosła

Re: Review Request: [GCI] Adding d-pointers (part #1)

2012-12-10 Thread Jarosław Staniek
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107610/#review23268 --- Please look step by step -- not all of the 4 issues have been r

Re: Review Request: [GCI] Adding d-pointers to kexi/formeditor

2012-12-10 Thread Andrey Inishev
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107647/ --- (Updated Dec. 10, 2012, 6:48 p.m.) Review request for Calligra and Jarosła

Re: Review Request: Tab Widget of the Tool option docker as Document Mode

2012-12-10 Thread Jarosław Staniek
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107659/#review23283 --- Ship it! I guess it's the same motivation as the one explained

[Junior Job] π in Calligra

2012-12-10 Thread Jaroslaw Staniek
Hi, If anyone feels like procrastinating feel free to reduce this redundancy somehow :) % ack 3.14159265 plugins/chartshape/kdchart/kdablibfakes/src/KDABLibFakes.h 42:#define M_PI 3.14159265358979323846 plugins/chartshape/kdchart/src/KDChartPolarCoordinatePlane.cpp 50:#define M_PI 3.141592653589

Re: Review Request: [GCI] Adding d-pointers to kexi/formeditor

2012-12-10 Thread Jarosław Staniek
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107647/#review23287 --- Please *carefully* fix that: kexi/formeditor/container.cpp

Re: Review Request: [GCI] Adding d-pointers to kexi/formeditor

2012-12-10 Thread Jarosław Staniek
> On Dec. 9, 2012, 11:45 p.m., Jarosław Staniek wrote: > > kexi/formeditor/container.cpp, line 1043 > > > > > > please move '{' to new row not fixed (4 methods) > On Dec. 9, 2012, 11:45 p.m., Jarosław Staniek wr

Re: Review Request: [GCI] Adding d-pointers to kexi/formeditor

2012-12-10 Thread Jarosław Staniek
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107647/#review23293 --- Afterwards please also fix build in kexi/plugins/forms/ and inc

Review Request: Kexi Core: add main context menu for all object windows

2012-12-10 Thread Jarosław Staniek
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107661/ --- Review request for Calligra, Adam Pigg, Dimitrios Tanis, Radosław Wicik, and

Re: Review Request: [GCI] Adding d-pointers (part #1)

2012-12-10 Thread Shou Ya
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107610/ --- (Updated Dec. 11, 2012, 6:45 a.m.) Review request for Calligra and Jarosła