Re: Review Request: rename "import" action to "open as new"

2012-08-20 Thread Thomas Pfeiffer
On Saturday 18 August 2012 22:24:51 Jaroslaw Staniek wrote: > > But an important one, and I'm thinking that if few people use this useful > > option it's because they don't really know what it does. Clarifying that > > would be a good thing, in my mind.> > >> Please note it's already redundant bec

Re: Review Request: rename "import" action to "open as new"

2012-08-20 Thread Boudewijn Rempt
On Monday 20 August 2012 Aug, Thomas Pfeiffer wrote: > I don't see how this saves users any keystrokes. Let's compare the task "Get > the content of an existing file and save it to a new file" with and without > this > feature, with the standard shortcut settings and leaving out interaction wit

Re: Review Request: add commands for chart operations

2012-08-20 Thread Brijesh Patel
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106070/ --- (Updated Aug. 20, 2012, 8:40 p.m.) Review request for Calligra, Inge Walli

Re: Review Request: rename "import" action to "open as new"

2012-08-20 Thread Jaroslaw Staniek
On 20 August 2012 21:26, Boudewijn Rempt wrote: > On Monday 20 August 2012 Aug, Thomas Pfeiffer wrote: > >> I don't see how this saves users any keystrokes. Let's compare the task "Get >> the content of an existing file and save it to a new file" with and without >> this >> feature, with the stan

Re: Review Request: Animation Tool Docker

2012-08-20 Thread Paul Mendez
> On Aug. 20, 2012, 5:55 p.m., Thorsten Zachmann wrote: > > stage/part/KPrShapeApplicationData.cpp, line 31 > > > > > > This seems to be a memory leak. Animations are deleted in KPrAnimationCreateCommand and KPrAni

Re: Review Request: Animation Tool Docker

2012-08-20 Thread Paul Mendez
> On Aug. 20, 2012, 5:55 p.m., Thorsten Zachmann wrote: > > stage/part/KPrShapeAnimations.cpp, lines 220-227 > > > > > > Can it happen that KPrShapeAnimation::none is true and there is no > > shape? Otherwise this

Re: Review Request: Animation Tool Docker

2012-08-20 Thread Paul Mendez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106093/ --- (Updated Aug. 21, 2012, 2:26 a.m.) Review request for Calligra. Changes

Re: Review Request: add commands for chart operations

2012-08-20 Thread Thorsten Zachmann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106070/#review17788 --- Ship it! Looks good. Please ship - Thorsten Zachmann On Aug

Re: Review Request: Animation Tool Docker

2012-08-20 Thread Thorsten Zachmann
> On Aug. 20, 2012, 5:55 p.m., Thorsten Zachmann wrote: > > stage/part/KPrShapeApplicationData.cpp, line 31 > > > > > > This seems to be a memory leak. > > Paul Mendez wrote: > Animations are deleted in KPrAnima

Re: Review Request: rename "import" action to "open as new"

2012-08-20 Thread Boudewijn Rempt
On Tuesday 21 August 2012 Aug, Jaroslaw Staniek wrote: > This is small subset from cases when user would like to have access to > history of edits. The extra command does not deliver this access but > puts a kind of macro on top for on case. Says you. I disagree. I also fail to understand why you