merging the libs-kodocument_split_boud_and_boemann branch

2012-07-23 Thread C. Boemann
Hi all I intend to merge the part+document branch real soon now. It is inevitable that we will have regressions so it's important that we have a long time to catch stuff before the next release. I know this goes against the rule of having a perfect branch before merging, but this branch is so h

Re: Review Request: fix KisPaintOpPresetsPopup to use an existing icon for the paintPresetIcon button

2012-07-23 Thread Boudewijn Rempt
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105669/#review16261 --- I'm actually totally unsure what this button does... I'm not ev

Re: merging the libs-kodocument_split_boud_and_boemann branch

2012-07-23 Thread Inge Wallin
On Monday, July 23, 2012 09:45:50 C. Boemann wrote: > Hi all > > I intend to merge the part+document branch real soon now. > > It is inevitable that we will have regressions so it's important that we > have a long time to catch stuff before the next release. I know this goes > against the rule of

Re: Review Request: fix KisPaintOpPresetsPopup to use an existing icon for the paintPresetIcon button

2012-07-23 Thread Friedrich W. H. Kossebau
> On July 23, 2012, 7:50 a.m., Boudewijn Rempt wrote: > > I'm actually totally unsure what this button does... I'm not even sure it's > > actually visible. I can now help you (had to hunt down where it is as well :) ) In the Krita toolbar click the "Edit brush settings" popup button, then look

Re: [PATCH] bad icon name in ReportDesignDialog( ReportView *, QWidget *)

2012-07-23 Thread Friedrich W. H. Kossebau
Am Montag, 23. Juli 2012, 08:32:19 schrieben Sie: > Søndag den 22. juli 2012 15:27:58 Friedrich W. H. Kossebau skrev: > > Hi Dag, > > > > seems that in ReportDesignDialog the icon used should be always > > "window-new" for the "Save To View" button, also in case of constructor > > "ReportDesignDia

Re: Really missing icons in C 2.5

2012-07-23 Thread Friedrich W. H. Kossebau
Am Sonntag, 22. Juli 2012, 21:46:06 schrieb Jaroslaw Staniek: > On 22 July 2012 21:05, Friedrich W. H. Kossebau wrote: > > Hi, > > > > so after another review of the missing icons, where I managed to find > > solutions for some (see e.g. today's small patch flood :) ), this email > > now > > migh

Review Request: [crash workaround] disable Voice combobox in SimpleEntryTool for Music shape

2012-07-23 Thread Friedrich W. H. Kossebau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105674/ --- Review request for Calligra and Marijn Kruisselbrink. Description ---

Review Request: gain more vertical pixels in slide sort view (unneeded margin around slideshow toolbar at bottom)

2012-07-23 Thread Friedrich W. H. Kossebau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105684/ --- Review request for Calligra and Thorsten Zachmann. Description --- Th

Re: Review Request: gain more vertical pixels in slide sort view (unneeded margin around slideshow toolbar at bottom)

2012-07-23 Thread Thorsten Zachmann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105684/#review16268 --- Ship it! Feel free to backport to 2.5 - Thorsten Zachmann O

Review Request: remove icons from "Add Slide/Page or Layer" menu (missing layer-new icon)

2012-07-23 Thread Friedrich W. H. Kossebau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105687/ --- Review request for Calligra. Description --- As there is no "layer-ne

Review Request: fix missing icons "edit-duplicate" & "edit-merge" by using "edit-copy" & no icon (Krita context menu on layers)

2012-07-23 Thread Friedrich W. H. Kossebau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105692/ --- Review request for Calligra and Boudewijn Rempt. Description --- In t

Review Request: fix missing icon "duplicate" in Braindump main menu

2012-07-23 Thread Friedrich W. H. Kossebau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105696/ --- Review request for Calligra and Cyrille Berger Skott. Description ---

Re: Review Request: gain more vertical pixels in slide sort view (unneeded margin around slideshow toolbar at bottom)

2012-07-23 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105684/#review16269 --- This review has been submitted with commit e97dfcdbd28138d47fb

Re: Review Request: gain more vertical pixels in slide sort view (unneeded margin around slideshow toolbar at bottom)

2012-07-23 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105684/#review16270 --- This review has been submitted with commit 0fdc9494afc663ef25f

Review Request: fix bad name of web shape tool which is still "State Tool"

2012-07-23 Thread Friedrich W. H. Kossebau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105700/ --- Review request for Calligra and Cyrille Berger Skott. Description ---

Re: Review Request: Fixed ' may be used uninitialized' warnings

2012-07-23 Thread Jarosław Staniek
> On July 16, 2012, 5:14 p.m., Friedrich W. H. Kossebau wrote: > > I wonder if it would no be a better fix to add a parameter for the default > > value to the macro STRING_TO_INT, to which the variable gets set if the > > string is empty. Might be more readable code not only to me. > > > > Onl

Re: Review Request: Fixed ' may be used uninitialized' warnings

2012-07-23 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105519/#review16279 --- This review has been submitted with commit d93a6abd243f8de3b2d

How to implement auto-formatting of text (e.g. syntax highlighting of code snippets)?

2012-07-23 Thread Friedrich W. H. Kossebau
Hi, feature, not bug this time :) As software developer you often have sourcecode snippets in your documents or slides. Now, ideally that code snippet has some syntax highlighting like you are used from your sourcecode editor. Of course, that should be done automatically, like in the editor, a