Re: plugin shape - delete or not

2012-04-22 Thread Boudewijn Rempt
On Saturday 21 April 2012 Apr, C. Boemann wrote: > Hi > > Trying to get the videoshape to work i ran into the problem that the plugin > shape is always loaded in priority of the video shape > > the plugin shape has a priority of 9 vs video shape having a normal 1, so > that > is obviously a bu

Re: Review Request: Add support for 3D scenes to libs/odf

2012-04-22 Thread Inge Wallin
> On April 22, 2012, 5:08 a.m., Thorsten Zachmann wrote: > > libs/odf/Ko3dScene.h, lines 79-80 > > > > > > You should pass the KoShapeLoadingContext and the KoShapeSavingContext > > to this methods so in case it is

Re: plugin shape - delete or not

2012-04-22 Thread Inge Wallin
On Sunday, April 22, 2012 09:35:36 Boudewijn Rempt wrote: > On Saturday 21 April 2012 Apr, C. Boemann wrote: > > Hi > > > > Trying to get the videoshape to work i ran into the problem that the > > plugin shape is always loaded in priority of the video shape > > > > the plugin shape has a priority

Re: Review Request: Add support for 3D scenes to libs/odf

2012-04-22 Thread Thorsten Zachmann
> On April 22, 2012, 5:08 a.m., Thorsten Zachmann wrote: > > libs/odf/Ko3dScene.cpp, line 150 > > > > > > The save method of the Ko3dScene should also save the tag drd3:screen > > tag. > > Inge Wallin wrote: >

Re: Review Request: Add support for 3D scenes to libs/odf

2012-04-22 Thread Inge Wallin
> On April 22, 2012, 5:08 a.m., Thorsten Zachmann wrote: > > libs/odf/Ko3dScene.cpp, line 150 > > > > > > The save method of the Ko3dScene should also save the tag drd3:screen > > tag. > > Inge Wallin wrote: >

Review Request: Removed warning for 2.5. Using int for return type becuase -1 is a valid return

2012-04-22 Thread Adam Pigg
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104691/ --- Review request for Calligra, Jarosław Staniek and Dag Andersen. Descriptio

KoReport ODT Renderer

2012-04-22 Thread Adam Pigg
Dag In Plan, i see you have your own ODT renderer. It appears to be more featureful than the one in libs/koreport, so perhaps you could move it there? Can you post a sample of what kind of ODT it produces? Adam ___ calligra-devel mailing list calligra

Re: Review Request: Removed warning for 2.5. Using int for return type becuase -1 is a valid return

2012-04-22 Thread Jarosław Staniek
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104691/#review12797 --- Ship it! Ship It! - Jarosław Staniek On April 22, 2012, 3:2

Review Request: Border ui for tables

2012-04-22 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104694/ --- Review request for Calligra. Description --- I've added a border-pain

Re: Review Request: Border ui for tables

2012-04-22 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104694/#review12800 --- forgot to mention that it can be tested with this branch: text

Re: Review Request: Fixes: show RulerTabChooser in right place, not somewhere on ruler, and only if needed/wanted

2012-04-22 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104666/#review12808 --- This review has been submitted with commit bfc712da8c2c116ffc8

Re: Review Request: Removed warning for 2.5. Using int for return type becuase -1 is a valid return

2012-04-22 Thread Jarosław Staniek
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104691/#review12812 --- Ship it! - Jarosław Staniek On April 22, 2012, 3:28 p.m., Ad

UX issues of forum.kde.org

2012-04-22 Thread Jaroslaw Staniek
Hi, just asked the KDE forum staff (they are doing great work) on the UX issues: http://forum.kde.org/viewtopic.php?f=9&t=101678&p=220274#p220274 In particular one wish for improving UX is related to my hope for having proper forum.calligra.org based on very the same database (especially doable a

Re: Review Request: Fixes: show RulerTabChooser in right place, not somewhere on ruler, and only if needed/wanted

2012-04-22 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104666/#review12817 --- This review has been submitted with commit 053e2027ace10f5170e