Re: Review Request: User defined variables (2)

2011-12-05 Thread Sebastian Sauer
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103276/ --- (Updated Dec. 5, 2011, 9:50 a.m.) Review request for Calligra and Thorsten

Re: Review Request: User defined variables (2)

2011-12-05 Thread Thorsten Zachmann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103276/#review8721 --- Ship it! Looks good. I say ship it but it contains some new str

some code warnings

2011-12-05 Thread Jaime
Hi,   Searching for dead code, I've seen some code that I do not know how to handle (not included in this list code that has a //todo or similar).. In case they are intended, please add a comment with a todo or fixme or whatever (or probably you will forget about them)   * There is a return in t

Re: some code warnings

2011-12-05 Thread Boudewijn Rempt
On Monday 05 December 2011 Dec, Jaime wrote: > * There is a return in the middle of void > KisFilterBumpmap::process(KisPaintDeviceSP device, const QRect& > applyRect, const KisFilterConfiguration* config, KoUpdater* > progressUpdater) const (line 225) > in krita/plugins/filters/bumpmap/bumpmap.c

Re: some code warnings

2011-12-05 Thread Thorsten Zachmann
Hello, On Monday, December 05, 2011 13:01:12 Jaime wrote: > * There is more code after the first return of KoShape * > KoPADocumentModel::childFromIndex( KoShapeContainer *parent, int row ) > const > > int KoPADocumentModel::indexFromChild( KoShapeContainer *parent, > KoShape *child ) const >