change to product names in bugzilla

2011-10-31 Thread C. Boemann
Hi I've changed all those calligra-product to calligraproduct in bugzilla so they match our application names. And calligra-karbon product is now just karbon This was needed as dr.konqi uses the application name to find the product This however means that you need to update any saved bugzilla qu

Re: change to product names in bugzilla

2011-10-31 Thread Cyrille Berger Skott
You also need to grep for setProductName and make sure they are accurate (I only checked for words, and it is set to calligra-words), otherwise "Help -> report bugs" is broken. Ideally drkonqi would also use productName from KAboutData, but that might not be that easy... On Monday 31 October 2

Re: change to product names in bugzilla

2011-10-31 Thread Sebastian Sauer
On 10/31/2011 11:26 AM, Cyrille Berger Skott wrote: You also need to grep for setProductName and make sure they are accurate (I only checked for words, and it is set to calligra-words), otherwise "Help -> report bugs" is broken. Ideally drkonqi would also use productName from KAboutData, but tha

Review Request: Fix crashing when using tools on empty image

2011-10-31 Thread Torio Mlshi
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103003/ --- Review request for Calligra. Summary (updated) - Fix cras

Re: Review Request: Fix crashing when using tools on empty image

2011-10-31 Thread Dmitry Kazakov
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103003/#review7782 --- Ship it! Thanks for the fix! =) Just two small things: 1) I th

Re: Review Request: Fix crashing when using tools on empty image

2011-10-31 Thread Torio Mlshi
> On Oct. 31, 2011, 7:43 p.m., Dmitry Kazakov wrote: > > Thanks for the fix! =) > > Just two small things: > > 1) I think it would be logical to reset the stroke id right after > > endStroke(m_strokeId) in mouseReleaseEvent() function. Like: > >image->endStroke(m_strokeId); > >m_strokeI

Review Request: Fix saving of hyperlink formating

2011-10-31 Thread Thorsten Zachmann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103008/ --- Review request for Calligra. Description --- When saving a hyperlink

Re: Review Request: Fix crashing when using tools on empty image

2011-10-31 Thread Boudewijn Rempt
On Monday 31 October 2011 Oct, Torio Mlshi wrote: > > > On Oct. 31, 2011, 7:43 p.m., Dmitry Kazakov wrote: > > > Thanks for the fix! =) > > > Just two small things: > > > 1) I think it would be logical to reset the stroke id right after > > > endStroke(m_strokeId) in mouseReleaseEvent() function

Re: Review Request: Show/Hide Tabs when project is opened/closed

2011-10-31 Thread Dimitrios Tanis
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102993/ --- (Updated Oct. 31, 2011, 10:40 p.m.) Review request for Calligra and Jarosł