Review Request: Try to provide inputmethod rect for all pages

2011-10-02 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102754/ --- Review request for Calligra and Yue Liu. Description --- Try and prov

Re: Review Request: Fix issue with loading unknown frame shapes and give the Unavail shape the ability to show preview pictures

2011-10-02 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101871/#review6995 --- shouldn't this be closed ? - C. Boemann On July 7, 2011, 6:59

Re: Review Request: make it possible to read properties from different property types.

2011-10-02 Thread Jan Hambrecht
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102737/#review6997 --- Ship it! I think beside the two things pointed out you could co

Re: Review Request: make it possible to read properties from different property types.

2011-10-02 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102737/#review6999 --- This review has been submitted with commit e99f47c4ad1c55bdfa25

Re: reviewboard hates me

2011-10-02 Thread Thorsten Zachmann
On Saturday, October 01, 2011 09:58:50 Boudewijn Rempt wrote: > It doesn't want to accept this patch, which I think needs at least a quick > eyeballing from others. Please find it attached. > > It's about splitting KoResourceManager: > > > KoResourceManager was used in two places: the canvas and

Re: Review Request: Fix issue with loading unknown frame shapes and give the Unavail shape the ability to show preview pictures

2011-10-02 Thread Inge Wallin
> On Oct. 2, 2011, 9:39 a.m., C. Boemann wrote: > > shouldn't this be closed ? Yes, it should. Closing. - Inge --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101871/#review6995

Re: reviewboard hates me

2011-10-02 Thread Boudewijn Rempt
On Monday 03 October 2011 Oct, Thorsten Zachmann wrote: > On Saturday, October 01, 2011 09:58:50 Boudewijn Rempt wrote: > > It doesn't want to accept this patch, which I think needs at least a quick > > eyeballing from others. Please find it attached. > > > > It's about splitting KoResourceManager