> On Oct. 1, 2011, 5:09 a.m., Thorsten Zachmann wrote:
> > Looks good. Please commit after fixing the pointed out.
> >
> > I'm not sure about the new classname KoShapeBasedDocumentBase. The
> > orrurence of two times Base somehow troubles me. How about renaming it to
> > KoShapeDocumentBase? T
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102679/#review6981
---
This review has been submitted with commit
b844d6f087f97fab2dc1
Hello Boud,
On Saturday, October 01, 2011 09:58:50 Boudewijn Rempt wrote:
> It doesn't want to accept this patch, which I think needs at least a quick
> eyeballing from others. Please find it attached.
I tried to apply the patch but it seems to be horrible broken so that was not
possible. Unders
On Saturday 01 October 2011 Oct, Thorsten Zachmann wrote:
> Hello Boud,
>
> On Saturday, October 01, 2011 09:58:50 Boudewijn Rempt wrote:
> > It doesn't want to accept this patch, which I think needs at least a quick
> > eyeballing from others. Please find it attached.
>
> I tried to apply the pa
Looks like there is again a export problem in ooxml filter:
Linking CXX shared module ..\..\..\bin\docximport.dll
Creating library ..\..\..\bin\docximport.lib and object
..\..\..\bin\docximport.exp
DocxXmlDocumentReader.obj : error LNK2019: unresolved external symbol
"__declspec(dllimport) pub
On Saturday 01 October 2011, Boudewijn Rempt wrote:
> On Saturday 01 October 2011 Oct, Thorsten Zachmann wrote:
> > Hello Boud,
> >
> > On Saturday, October 01, 2011 09:58:50 Boudewijn Rempt wrote:
> > > It doesn't want to accept this patch, which I think needs at least a
> > > quick eyeballing fr
