Re: Review Request: Move several commands from TextTool to the KoTextEditor interface

2011-09-23 Thread Pierre Stirnweiss
I thought we had planned to discuss the kotext/textlayout/textshape architecture at the sprint. Pierre On Thu, Sep 22, 2011 at 10:08 PM, C. Boemann wrote: >This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/102679/ > > In general quite nice. A f

Re: Review Request: Move several commands from TextTool to the KoTextEditor interface

2011-09-23 Thread C. Boemann
Well yes but i thought we agreed on this. I mean, do you think this is not a step in the right direction? On Friday 23 September 2011 09:56:00 Pierre Stirnweiss wrote: > I thought we had planned to discuss the kotext/textlayout/textshape > architecture at the sprint. > > Pierre > > On Thu, Se

Re: Review Request: Move several commands from TextTool to the KoTextEditor interface

2011-09-23 Thread Pierre Stirnweiss
I didn't mean to make an assessement on the patch actually. I was answering to the IRC suggestion actually. I indeed personnaly think that the textshape is not the place for the commands. However, we should also try to keep an open mind for the exercise at the sprint. Otherwise we might format ours

Re: Review Request: Move several commands from TextTool to the KoTextEditor interface

2011-09-23 Thread Boudewijn Rempt
On Friday 23 September 2011 Sep, Pierre Stirnweiss wrote: > I didn't mean to make an assessement on the patch actually. I was answering > to the IRC suggestion actually. I indeed personnaly think that the textshape > is not the place for the commands. > However, we should also try to keep an open m

Re: Review Request: Move several commands from TextTool to the KoTextEditor interface

2011-09-23 Thread C. Boemann
ah the irc suggestion was on the specifics of a paste method, and not related to architecture have fun On Friday 23 September 2011 10:10:13 Pierre Stirnweiss wrote: > I didn't mean to make an assessement on the patch actually. I was answering > to the IRC suggestion actually. I indeed personnaly

Re: Review Request: Move several commands from TextTool to the KoTextEditor interface

2011-09-23 Thread Boudewijn Rempt
> On Sept. 22, 2011, 8:08 p.m., C. Boemann wrote: > > In general quite nice. A few remarks, and then i just assumed you moved the > > commands with maybe a little rename but i din't exactly read all of them. > > Please advice if i need to. > > > > > > For the kotexteditor::paste i think we sh

Re: Review Request: Move several commands from TextTool to the KoTextEditor interface

2011-09-23 Thread Boudewijn Rempt
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102679/ --- (Updated Sept. 23, 2011, 8:44 a.m.) Review request for Calligra. Changes

Re: Review Request: Move several commands from TextTool to the KoTextEditor interface

2011-09-23 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102679/#review6760 --- Ship it! - C. On Sept. 23, 2011, 8:44 a.m., Boudewijn Rempt w

Screenshots and calligra-suite.org

2011-09-23 Thread Cyrille Berger Skott
Hi, Most of the screenshots for words, tables and stage appear to be missing, did someone remove them on purpose ? And if so what was the plan behind it ? -- Cyrille Berger Skott ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.

Re: Review Request: Fix regression in size of shape groups with a lot of shapes

2011-09-23 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102645/#review6771 --- This review has been submitted with commit d157fb7554710d7c4789