Re: some code warnings

2011-12-11 Thread Jan Hambrecht
On Monday 05 December 2011 13:01:12 Jaime wrote: > Hi, > > Searching for dead code, I've seen some code that I do not know how > to handle (not included in this list code that has a //todo or > similar).. > > In case they are intended, please add a comment with a todo or fixme > or whatever (or

Re: some code warnings

2011-12-10 Thread Gopalakrishna Bhat
> * There is some code after the return in QVariant > TableOfContentsStyleModel::data(const QModelIndex &index, int role) > const (line 90) > in plugins/textshare/dialogs/TableOfContestsStyleModel.cpp > > Thanks for pointing it out. Fixed -- My blog http://gkbhat.blogspot.com _

Re: some code warnings

2011-12-05 Thread Thorsten Zachmann
Hello, On Monday, December 05, 2011 13:01:12 Jaime wrote: > * There is more code after the first return of KoShape * > KoPADocumentModel::childFromIndex( KoShapeContainer *parent, int row ) > const > > int KoPADocumentModel::indexFromChild( KoShapeContainer *parent, > KoShape *child ) const >

Re: some code warnings

2011-12-05 Thread Boudewijn Rempt
On Monday 05 December 2011 Dec, Jaime wrote: > * There is a return in the middle of void > KisFilterBumpmap::process(KisPaintDeviceSP device, const QRect& > applyRect, const KisFilterConfiguration* config, KoUpdater* > progressUpdater) const (line 225) > in krita/plugins/filters/bumpmap/bumpmap.c

some code warnings

2011-12-05 Thread Jaime
Hi,   Searching for dead code, I've seen some code that I do not know how to handle (not included in this list code that has a //todo or similar).. In case they are intended, please add a comment with a todo or fixme or whatever (or probably you will forget about them)   * There is a return in t