Re: removing module specifiers from includes

2012-02-08 Thread Cyrille Berger Skott
On Monday 06 Feb 2012, Jaroslaw Staniek wrote: > On 6 February 2012 21:22, Cyrille Berger Skott wrote: > > No objections from me. > > > > On Monday 06 Feb 2012, Boudewijn Rempt wrote: > >> Of course, this is only the first step, those files where do just > >> #include will give us trouble when p

Re: removing module specifiers from includes

2012-02-07 Thread Boudewijn Rempt
On Monday 06 February 2012 Feb, Jaroslaw Staniek wrote: > On 6 February 2012 21:22, Cyrille Berger Skott wrote: > > No objections from me. > > > > On Monday 06 Feb 2012, Boudewijn Rempt wrote: > >> Of course, this is only the first step, those files where do just #include > >> will give us troubl

Re: removing module specifiers from includes

2012-02-06 Thread Jaroslaw Staniek
On 6 February 2012 21:22, Cyrille Berger Skott wrote: > No objections from me. > > On Monday 06 Feb 2012, Boudewijn Rempt wrote: >> Of course, this is only the first step, those files where do just #include >> will give us trouble when porting to Qt5, but there are only about >> a hundred cases o

Re: removing module specifiers from includes

2012-02-06 Thread Cyrille Berger Skott
No objections from me. On Monday 06 Feb 2012, Boudewijn Rempt wrote: > Of course, this is only the first step, those files where do just #include > will give us trouble when porting to Qt5, but there are only about > a hundred cases of that... Those includes are bad anyway... I wish Qt5 would do

Re: removing module specifiers from includes

2012-02-06 Thread Boudewijn Rempt
On Mon, 6 Feb 2012, Arjen Hiemstra wrote: On Monday 06 Feb 2012 15:13:01 Boudewijn Rempt wrote: Hi, I've got a patch ready that changes all style includes to . The reason is that with Qt5, QtGui will split into QtGui and QtWidgets. The module specifiers actually only lead to churn, and there

Re: removing module specifiers from includes

2012-02-06 Thread Arjen Hiemstra
On Monday 06 Feb 2012 15:13:01 Boudewijn Rempt wrote: > Hi, > > I've got a patch ready that changes all style includes to > . The reason is that with Qt5, QtGui will split into QtGui and > QtWidgets. > > The module specifiers actually only lead to churn, and there is no > discernable advantage t

removing module specifiers from includes

2012-02-06 Thread Boudewijn Rempt
Hi, I've got a patch ready that changes all style includes to . The reason is that with Qt5, QtGui will split into QtGui and QtWidgets. The module specifiers actually only lead to churn, and there is no discernable advantage to them; all KDE applications have all Qt modules in their include