D27056: Stage: Add automatic slide transition

2020-02-05 Thread Dag Andersen
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R8:4f4141727401: Stage: Add automatic slide transition (authored by danders). REPOSITORY R8 Calligra CHANGES

D27056: Stage: Add automatic slide transition

2020-01-31 Thread Dag Andersen
by this patch. See bug 416979. REPOSITORY R8 Calligra BRANCH pagetransition_danders REVISION DETAIL https://phabricator.kde.org/D27056 AFFECTED FILES stage/part/CMakeLists.txt stage/part/KPrAnimationDirector.cpp stage/part/KPrAnimationDirector.h stage/part/KPrPage.cpp stage

Re: Review Request 125491: Fix crash when exiting Stage and the presentation mode is still on

2015-10-05 Thread David Faure
in the dtor, before the KPrDocument is destroyed. Diffs - stage/part/KPrView.cpp 432bc5e023f41a8927cbe9e854b2205962ae4e4b Diff: https://git.reviewboard.kde.org/r/125491/diff/ Testing --- Thanks, David Faure ___ calligra-devel mailing

Re: Many questions for Stage

2015-10-04 Thread Thorsten Zachmann
ike #RRGGBB? Or did I miss it? Seems you are right I was also not able to find one. There is something if you go on editing colors but I never found the color I added. > * The "connect shapes" tool in Stage only works with paths that I had > imported from an ooimpress presentation.

Stage

2015-10-03 Thread Adam Pigg
Last week at a local geek gathering (Code Cumbria) there were some presentations given. It seems the 'in' presenting tool is Decksets for mac (http://www.decksetapp.com/). The idea is you create the presentation using a simple markdown file, and the app just creates/themes the slides with built i

Re: Review Request 125491: Fix crash when exiting Stage and the presentation mode is still on

2015-10-02 Thread Thorsten Zachmann
ct. 2, 2015, 9:13 p.m.) > > > Review request for Calligra and Thorsten Zachmann. > > > Repository: calligra > > > Description > --- > > (i.e. F5, Alt+Tab, Alt+F4). Fix: exiting presentation mode in the dtor, > before the KPrDocument is de

Review Request 125491: Fix crash when exiting Stage and the presentation mode is still on

2015-10-02 Thread David Faure
Description --- (i.e. F5, Alt+Tab, Alt+F4). Fix: exiting presentation mode in the dtor, before the KPrDocument is destroyed. Diffs - stage/part/KPrView.cpp 432bc5e023f41a8927cbe9e854b2205962ae4e4b Diff: https://git.reviewboard.kde.org/r/125491/diff/ Testing --- Thanks

Re: Many questions for Stage

2015-10-02 Thread Jos van den Oever
On 10/02/2015 10:53 AM, C. Boemann wrote: * I miss the "reopen on the page/slide where I was when closing the app" feature. I had code for that in KWord (and in the ODF specs) long ago... I can't really remember what it was though. Maybe something in meta.xml or so. it's not in Words either, but

Re: Many questions for Stage

2015-10-02 Thread C. Boemann
but the #RRGGBB was left out intentionally as it clashes a bit with the coor independence idea - but thinking back it might make sense to assume sRGB profile for those values (however that does mean that not all values will produce a valid color and not all colors will have a name) > * The &

Re: Many fixes for Stage

2015-10-02 Thread Thorsten Zachmann
Hello David, On 2015-10-02 09:52, David Faure wrote: I used Stage to make a presentation yesterday, and I have many bugfixes to submit (and then some questions, and some bug reports). I just pushed the trivial fixes (typos and cleanups), but how do you want the patches for the more substantial

Re: Many fixes for Stage

2015-10-02 Thread Boudewijn Rempt
Pushed, also to master On Fri, 2 Oct 2015, Boudewijn Rempt wrote: On Fri, 2 Oct 2015, Boudewijn Rempt wrote: In addition: why did this commit to calligra/2.8 was never merged to calligra/2.9? http://osdir.com/ml/kde-commits/2014-09/msg00859.html Was I supposed to forwardport my commits rat

Re: Many fixes for Stage

2015-10-02 Thread Boudewijn Rempt
On Fri, 2 Oct 2015, Boudewijn Rempt wrote: In addition: why did this commit to calligra/2.8 was never merged to calligra/2.9? http://osdir.com/ml/kde-commits/2014-09/msg00859.html Was I supposed to forwardport my commits rather than relying on a regular git merge? Hm, I might have missed th

Re: Many fixes for Stage

2015-10-02 Thread Boudewijn Rempt
On Fri, 2 Oct 2015, David Faure wrote: I used Stage to make a presentation yesterday, and I have many bugfixes to submit (and then some questions, and some bug reports). I just pushed the trivial fixes (typos and cleanups), but how do you want the patches for the more substantial ones

Many questions for Stage

2015-10-02 Thread David Faure
n". Shouldn't it? I expected it to. * Color selection: there's no color picker and no way to just type a color name like #RRGGBB? Or did I miss it? * The "connect shapes" tool in Stage only works with paths that I had imported from an ooimpress presentation. More precise

Many fixes for Stage

2015-10-02 Thread David Faure
I used Stage to make a presentation yesterday, and I have many bugfixes to submit (and then some questions, and some bug reports). I just pushed the trivial fixes (typos and cleanups), but how do you want the patches for the more substantial ones? Reviewboard? Phabricator? Patch on ML? Just push

[calligra] /: Unport words, stage and sheets again

2015-09-11 Thread Boudewijn Rempt
Git commit 820adc96cda98f0f47c4077213e239402e33f03e by Boudewijn Rempt. Committed on 11/09/2015 at 13:13. Pushed by rempt into branch 'master'. Unport words, stage and sheets again They need to be ported from KIcon to QIcon now... CCMAIL:calligra-devel@kde.org M

Re: [calligra] /: Unport words and stage

2015-09-11 Thread Boudewijn Rempt
On Fri, 11 Sep 2015, Friedrich W. H. Kossebau wrote: Am Freitag, 11. September 2015, 08:26:41 schrieb Boudewijn Rempt: Git commit 43a5919cbadcd4b59f4a75448323ef70571209c0 by Boudewijn Rempt. Committed on 11/09/2015 at 08:25. Pushed by rempt into branch 'master'. Unport words

Re: [calligra] /: Unport words and stage

2015-09-11 Thread Friedrich W. H. Kossebau
Am Freitag, 11. September 2015, 08:26:41 schrieb Boudewijn Rempt: > Git commit 43a5919cbadcd4b59f4a75448323ef70571209c0 by Boudewijn Rempt. > Committed on 11/09/2015 at 08:25. > Pushed by rempt into branch 'master'. > > Unport words and stage Ported a

[calligra] /: Unport words and stage

2015-09-11 Thread Boudewijn Rempt
Git commit 43a5919cbadcd4b59f4a75448323ef70571209c0 by Boudewijn Rempt. Committed on 11/09/2015 at 08:25. Pushed by rempt into branch 'master'. Unport words and stage After porting libs and plugins from QAction to KAction and KShortcut to QKeySequence, stage and words need to be po

Re: How to modify or create my own slide layouts in Stage?

2015-03-22 Thread Henrik Ingo
On Sun, Mar 22, 2015 at 11:40 AM, Thorsten Zachmann wrote: >> In Stage, is it possible, and how, to create my own slide layouts? For >> example, if I choose the KDE Events teamplate, I can see that in the >> title slide the title text is in the middle of the slide, not at the &

Re: How to modify or create my own slide layouts in Stage?

2015-03-22 Thread Thorsten Zachmann
right now in that agonizing period where the software > is definitively looking usable, yet documentation is still so scarce I > sometimes cannot do what I want. (Including searching for > stackoverflow or other forums.) So I hope this mailing list will help > me. > > In Stage, is

How to modify or create my own slide layouts in Stage?

2015-03-20 Thread Henrik Ingo
times cannot do what I want. (Including searching for stackoverflow or other forums.) So I hope this mailing list will help me. In Stage, is it possible, and how, to create my own slide layouts? For example, if I choose the KDE Events teamplate, I can see that in the title slide the title text is i

Re: Review Request 120756: Fix for bug 306097 - find does not work on the full document (Stage)

2014-10-23 Thread Fredy Yanardi
Calligra. > > > Bugs: 306097 > http://bugs.kde.org/show_bug.cgi?id=306097 > > > Repository: calligra > > > Description > --- > > Fix for bug 306097 - Find does not work on the full document (Stage). Find > does not work because when no text shape is

Re: Review Request 120756: Fix for bug 306097 - find does not work on the full document (Stage)

2014-10-23 Thread Fredy Yanardi
r bug 306097 - Find does not work on the full document (Stage). Find does not work because when no text shape is active, KoPAView is not triggered to select the next text shape. Diffs (updated) - libs/kotext/KoFind_p.cpp c4143b9 libs/kopageapp/KoPAView.cpp 6e0b519 libs/k

Re: Review Request 120756: Fix for bug 306097 - find does not work on the full document (Stage)

2014-10-23 Thread Camilla Boemann
Oct. 23, 2014, 4:16 p.m.) > > > Review request for Calligra. > > > Bugs: 306097 > http://bugs.kde.org/show_bug.cgi?id=306097 > > > Repository: calligra > > > Description > --- > > Fix for bug 306097 - Find does not work on the full docu

Review Request 120756: Fix for bug 306097 - find does not work on the full document (Stage)

2014-10-23 Thread Fredy Yanardi
/show_bug.cgi?id=306097 Repository: calligra Description --- Fix for bug 306097 - Find does not work on the full document (Stage). Find does not work because when no text shape is active, KoPAView is not triggered to select the next text shape. Diffs - libs/kopageapp/KoPAView.cpp

Re: Review Request 120572: Unbreak Stage: remove duplicated loading of Flake plugins from KoToolRegistry

2014-10-15 Thread Friedrich W. H. Kossebau
marked as submitted. Review request for Calligra, Boudewijn Rempt and Thorsten Zachmann. Repository: calligra Description --- If you load a file into Stage from current master, you see a lot of "Unknown shapes" on the screen (possibly mapping to some question marks in your hea

Re: Review Request 120572: Unbreak Stage: remove duplicated loading of Flake plugins from KoToolRegistry

2014-10-15 Thread Boudewijn Rempt
t. 13, 2014, 5:13 p.m.) > > > Review request for Calligra, Boudewijn Rempt and Thorsten Zachmann. > > > Repository: calligra > > > Description > --- > > If you load a file into Stage from current master, you see a lot of "Unknown > shapes" on the s

Review Request 120572: Unbreak Stage: remove duplicated loading of Flake plugins from KoToolRegistry

2014-10-13 Thread Friedrich W. H. Kossebau
. Repository: calligra Description --- If you load a file into Stage from current master, you see a lot of "Unknown shapes" on the screen (possibly mapping to some question marks in your head). Seems the plugins for Text shapes and Vector shapes are not available. I tried to find an

Re: Review Request 120342: Give Stage- and KoPA-specific tools own service types (fixes crash in Braindump and for me Flow)

2014-09-30 Thread Friedrich W. H. Kossebau
marked as submitted. Review request for Calligra, Cyrille Berger Skott, Yue Liu, Boudewijn Rempt, and Thorsten Zachmann. Repository: calligra Description --- Currently blacklisting is done for the two Stage- and KoPA-specific tools calligrastagetoolanimation and kopabackgroundtool in

Re: Review Request 120342: Give Stage- and KoPA-specific tools own service types (fixes crash in Braindump and for me Flow)

2014-09-27 Thread Friedrich W. H. Kossebau
reply, visit: > https://git.reviewboard.kde.org/r/120342/ > --- > > (Updated Sept. 24, 2014, 9:24 p.m.) > > > Review request for Calligra, Cyrille Berger Skott, Yue Liu, Boudewijn Rempt, > and Thorsten Zachmann. > > > Repository: calligra > > > D

Re: Review Request 120342: Give Stage- and KoPA-specific tools own service types (fixes crash in Braindump and for me Flow)

2014-09-26 Thread Thorsten Zachmann
empt, > and Thorsten Zachmann. > > > Repository: calligra > > > Description > --- > > Currently blacklisting is done for the two Stage- and KoPA-specific tools > calligrastagetoolanimation and kopabackgroundtool in all apps (not done for > Braindump becau

Re: Review Request 120342: Give Stage- and KoPA-specific tools own service types (fixes crash in Braindump and for me Flow)

2014-09-25 Thread Friedrich W. H. Kossebau
it.reviewboard.kde.org/r/120342/ > --- > > (Updated Sept. 24, 2014, 9:24 p.m.) > > > Review request for Calligra, Cyrille Berger Skott, Yue Liu, Boudewijn Rempt, > and Thorsten Zachmann. > > > Repository: calligra > > > Description > ---

Re: Review Request 120342: Give Stage- and KoPA-specific tools own service types (fixes crash in Braindump and for me Flow)

2014-09-25 Thread Boudewijn Rempt
.kde.org/r/120342/ > --- > > (Updated Sept. 24, 2014, 9:24 p.m.) > > > Review request for Calligra, Cyrille Berger Skott, Yue Liu, Boudewijn Rempt, > and Thorsten Zachmann. > > > Repository: calligra > > > Description > --- >

Review Request 120342: Give Stage- and KoPA-specific tools own service types (fixes crash in Braindump and for me Flow)

2014-09-24 Thread Friedrich W. H. Kossebau
Rempt, and Thorsten Zachmann. Repository: calligra Description --- Currently blacklisting is done for the two Stage- and KoPA-specific tools calligrastagetoolanimation and kopabackgroundtool in all apps (not done for Braindump because there is no default braindumprc with an

Re: Review Request 120011: Let Ctrl+Home/Ctrl+End go to top and bottom of text shape in stage.

2014-09-04 Thread David Faure
hape/TextTool.h 340929215def4c254ec4c62bd7ffc140adf02ebf plugins/textshape/TextTool.cpp 2bf8787816c100dbd7acde8ac730e91676a3ac41 stage/part/KPrViewModeNotes.h f1f008063c3c3f6e73349817161f9aa3f5cdc170 stage/part/KPrViewModeNotes.cpp 4cca0212e09c1b96a1bf864e8116eb96b35bf4f

Re: Review Request 120011: Let Ctrl+Home/Ctrl+End go to top and bottom of text shape in stage.

2014-09-03 Thread Thorsten Zachmann
/KoPAViewMode.h 043b27c7273230d4dea368c2e2bc7a7dead2983f > libs/kopageapp/KoPAViewModeNormal.h > 86b1e0422b7dfead2b47cee8858632a36fdc5d46 > libs/kopageapp/KoPAViewModeNormal.cpp > faba4dd9e6eda1ad7a4bc171b6f8e5d6ac0e1055 > plugins/textshape/TextToo

Review Request 120011: Let Ctrl+Home/Ctrl+End go to top and bottom of text shape in stage.

2014-08-30 Thread David Faure
pe/TextTool.cpp 2bf8787816c100dbd7acde8ac730e91676a3ac41 stage/part/KPrViewModeNotes.h f1f008063c3c3f6e73349817161f9aa3f5cdc170 stage/part/KPrViewModeNotes.cpp 4cca0212e09c1b96a1bf864e8116eb96b35bf4f6 stage/part/KPrViewModePresentation.h 99d14dad95de9ac62b5cdb98c42c4040d0ee0488 stage/part/KPrViewModeP

Re: Review Request 111747: stage uses modebox, modebox capable of horizontal mode, various fixes

2013-09-04 Thread Commit Hook
plugins/dockers/styledocker/StylePreview.h da81351 plugins/dockers/styledocker/StylePreview.cpp e196fe3 plugins/textshape/dialogs/SimpleTableWidget.ui cf9efa0 stage/part/CMakeLists.txt 65b956e stage/part/KPrPageLayoutWidget.h PRE-CREATION stage/part/KPrPageLayoutWidget.cpp PRE-CREATION

Re: Review Request 111747: stage uses modebox, modebox capable of horizontal mode, various fixes

2013-09-04 Thread Commit Hook
s/styledocker/StyleDockerFactory.cpp 5898610 > plugins/dockers/styledocker/StylePreview.h da81351 > plugins/dockers/styledocker/StylePreview.cpp e196fe3 > plugins/textshape/dialogs/SimpleTableWidget.ui cf9efa0 > stage/part/CMakeLists.txt 65b956e > stage/part/KPrPageLayoutWi

Re: Review Request 111747: stage uses modebox, modebox capable of horizontal mode, various fixes

2013-08-28 Thread C. Boemann
plugins/dockers/styledocker/StylePreview.h da81351 plugins/dockers/styledocker/StylePreview.cpp e196fe3 plugins/textshape/dialogs/SimpleTableWidget.ui cf9efa0 stage/part/CMakeLists.txt 65b956e stage/part/KPrPageLayoutWidget.h PRE-CREATION stage/part/KPrPageLayoutWidget.cpp PRE-CREATION

Re: Review Request 111747: stage uses modebox, modebox capable of horizontal mode, various fixes

2013-08-28 Thread Boudewijn Rempt
f86be9 > plugins/dockers/styledocker/StyleDockerFactory.h acd91ac > plugins/dockers/styledocker/StyleDockerFactory.cpp 5898610 > plugins/dockers/styledocker/StylePreview.h da81351 > plugins/dockers/styledocker/StylePreview.cpp e196fe3 > plugins/formulashape/cal

Re: Review Request 111747: stage uses modebox, modebox capable of horizontal mode, various fixes

2013-08-28 Thread C. Boemann
-deferred.desktop 7af9449 sheets/shape/calligra_shape_spreadsheet.desktop ac914fb sheets/sheets_viewplugin.desktop 6475c8a stage/part/CMakeLists.txt 65b956e stage/part/KPrPageLayoutWidget.h PRE-CREATION stage/part/KPrPageLayoutWidget.cpp PRE-CREATION stage/part/KPrView.cpp 6ec2402

Re: Review Request 111747: stage uses modebox, modebox capable of horizontal mode, various fixes

2013-08-22 Thread Thorsten Zachmann
> plugins/dockers/styledocker/StyleDockerFactory.h acd91ac > plugins/dockers/styledocker/StyleDockerFactory.cpp 5898610 > plugins/dockers/styledocker/StylePreview.h da81351 > plugins/dockers/styledocker/StylePreview.cpp e196fe3 > plugins/textshape/TextShape.h 8190ab1 &

Re: Review Request 111747: stage uses modebox, modebox capable of horizontal mode, various fixes

2013-08-21 Thread Thorsten Zachmann
gins/dockers/styledocker/StyleDocker.cpp 9f86be9 > plugins/dockers/styledocker/StyleDockerFactory.h acd91ac > plugins/dockers/styledocker/StyleDockerFactory.cpp 5898610 > plugins/dockers/styledocker/StylePreview.h da81351 > plugins/dockers/styledocker/StylePreview.c

Re: Review Request 111747: stage uses modebox, modebox capable of horizontal mode, various fixes

2013-08-20 Thread C. Boemann
86be9 > plugins/dockers/styledocker/StyleDockerFactory.h acd91ac > plugins/dockers/styledocker/StyleDockerFactory.cpp 5898610 > plugins/dockers/styledocker/StylePreview.h da81351 > plugins/dockers/styledocker/StylePreview.cpp e196fe3 > plugins/textshape/TextShape.h 8190ab1 &

Re: Review Request 111747: stage uses modebox, modebox capable of horizontal mode, various fixes

2013-08-20 Thread Thorsten Zachmann
leDockerFactory.cpp 5898610 > plugins/dockers/styledocker/StylePreview.h da81351 > plugins/dockers/styledocker/StylePreview.cpp e196fe3 > plugins/textshape/TextShape.h 8190ab1 > plugins/textshape/dialogs/SimpleTableWidget.ui cf9efa0 > stage/part/CMakeLists

Re: Review Request 111747: stage uses modebox, modebox capable of horizontal mode, various fixes

2013-07-30 Thread C. Boemann
/SimpleTableWidget.ui cf9efa0 stage/part/CMakeLists.txt 87df86c stage/part/KPrPageLayoutWidget.h PRE-CREATION stage/part/KPrPageLayoutWidget.cpp PRE-CREATION stage/part/KPrView.cpp fd6b762 stage/part/dockers/KPrPageLayoutDocker.h ed7a547 stage/part/dockers/KPrPageLayoutDocker.cpp 8348e2c words/part

Re: Review Request 111747: stage uses modebox, modebox capable of horizontal mode, various fixes

2013-07-30 Thread C. Boemann
e196fe3 plugins/textshape/TextShape.h 8190ab1 plugins/textshape/dialogs/SimpleTableWidget.ui cf9efa0 stage/part/CMakeLists.txt 87df86c stage/part/KPrPageLayoutWidget.h PRE-CREATION stage/part/KPrPageLayoutWidget.cpp PRE-CREATION stage/part/KPrView.cpp fd6b762 stage/part/dockers

Re: Review Request 111747: stage uses modebox, modebox capable of horizontal mode, various fixes

2013-07-29 Thread Jean-Nicolas Artaud
84 > plugins/dockers/styledocker/StyleDockerFactory.h acd91ac > plugins/dockers/styledocker/StyleDockerFactory.cpp 5898610 > plugins/dockers/styledocker/StylePreview.h 4dd5ac3 > plugins/dockers/styledocker/StylePreview.cpp 3b0865d > plugins/textshape/TextShape.h 8190ab1 &g

Re: Review Request 111747: stage uses modebox, modebox capable of horizontal mode, various fixes

2013-07-27 Thread C. Boemann
edocker/StyleDockerFactory.h acd91ac > plugins/dockers/styledocker/StyleDockerFactory.cpp 5898610 > plugins/dockers/styledocker/StylePreview.h 4dd5ac3 > plugins/dockers/styledocker/StylePreview.cpp 3b0865d > plugins/textshape/TextShape.h 8190ab1 > plugins/textshape/dia

Review Request 111747: stage uses modebox, modebox capable of horizontal mode, various fixes

2013-07-27 Thread C. Boemann
plugins/dockers/styledocker/StylePreview.h 4dd5ac3 plugins/dockers/styledocker/StylePreview.cpp 3b0865d plugins/textshape/TextShape.h 8190ab1 plugins/textshape/dialogs/SimpleTableWidget.ui cf9efa0 stage/part/CMakeLists.txt 87df86c stage/part/KPrPageLayoutWidget.h PRE-CREATION

Re: Review Request 109002: Turning stage into modebox

2013-03-25 Thread Jean-Nicolas Artaud
discarded. Review request for Calligra and C. Boemann. Description --- Turns stage into modebox. Totaly remove the Stroke and Fill docker. Add the background fill widget, especialy needed in stage. Diffs - flow/part/FlowView.cpp b30dbe9 libs/kopageapp/KoPAView.h 80b9f78 libs

Re: Review Request 109260: Normalize SIGNAL and SLOT signatures in Stage

2013-03-06 Thread Commit Hook
h fixsrc.py. > By now I think it's 99% certain that it's correct but I still want somebody > who knows the code to look through it. > > > Diffs > - > > stage/part/KPrAnimationDirector.cpp 4b3a50d > stage/part/KPrHtmlExport.cpp 9a9fc1c >

Re: Review Request 109082: Separate files for the app into own subdir "app/" for Stage and Words

2013-03-05 Thread Commit Hook
t the app-related files from the part/ directory makes the > sources easier to grasp (should also help beginners with Calligra code). And > it also results in having the complete sources for the product "Stage > executable" and "Words executable" in a separate dir s

Re: Review Request 109260: Normalize SIGNAL and SLOT signatures in Stage

2013-03-04 Thread Thorsten Zachmann
still want somebody > who knows the code to look through it. > > > Diffs > - > > stage/part/KPrAnimationDirector.cpp 4b3a50d > stage/part/KPrHtmlExport.cpp 9a9fc1c > stage/part/KPrPart.cpp 84e4867 > stage/part/KPrPresent

Re: Review Request 109260: Normalize SIGNAL and SLOT signatures in Stage

2013-03-04 Thread Inge Wallin
hey are not shown in Reviewboard. > On March 3, 2013, 6:14 p.m., Thorsten Zachmann wrote: > > stage/part/KPrViewModeSlidesSorter.cpp, line 318 > > <http://git.reviewboard.kde.org/r/109260/diff/1/?file=116695#file116695line318> > > > > Is this removing of whitesp

Re: Review Request 109260: Normalize SIGNAL and SLOT signatures in Stage

2013-03-03 Thread Thorsten Zachmann
difference in reviewboard? stage/part/KPrViewModeSlidesSorter.cpp <http://git.reviewboard.kde.org/r/109260/#comment21279> Is this removing of whitespace necessary? Having a blank after a , makes it more readable? - Thorsten Zachmann On March 3, 2013, 3:30 p.m., Inge Wallin

Review Request 109260: Normalize SIGNAL and SLOT signatures in Stage

2013-03-03 Thread Inge Wallin
--- This is a normalization of SIGNAL and SLOT calls that is done with fixsrc.py. By now I think it's 99% certain that it's correct but I still want somebody who knows the code to look through it. Diffs - stage/part/KPrAnimationDirector.cpp 4b3a50d stage/part/KPrHtmlExport.c

Re: Review Request 109002: Turning stage into modebox

2013-02-28 Thread Jean-Nicolas Artaud
. Boemann. Changes --- (first, I want you to know that I'm sorry for the time it takes me to correct the things you pointed out) This patch tries to fix the troubles you show me Zagge. It has been pushed and tested in the stage-designtool2-boemann branch. Description --- Turns stage

Re: Review Request 109082: Separate files for the app into own subdir "app/" for Stage and Words

2013-02-26 Thread Friedrich W. H. Kossebau
Description > --- > > Splitting out the app-related files from the part/ directory makes the > sources easier to grasp (should also help beginners with Calligra code). And > it also results in having the complete sources for the product "Stage > executable" and

Re: Problems with Calligra Active and mimetypes (was: Re: Review Request 108996: update calligraactive.desktop: sync mimetypes with those of Sheets, Stage, Words, remove outdated entries)

2013-02-26 Thread Friedrich W. H. Kossebau
Hi Shantanu, Am Dienstag, 26. Februar 2013, 22:10:58 schrieb Shantanu Tushar Jha: > I have mixed feelings when I think about having a touch UI for each of the > Calligra apps separately. On one side there are advantages that you > mentioned, but then it seems as if there will be too much work and/

Re: Review Request 109082: Separate files for the app into own subdir "app/" for Stage and Words

2013-02-26 Thread Inge Wallin
part/ directory makes the > sources easier to grasp (should also help beginners with Calligra code). And > it also results in having the complete sources for the product "Stage > executable" and "Words executable" in a separate dir structure, so decision > about bui

Re: Problems with Calligra Active and mimetypes (was: Re: Review Request 108996: update calligraactive.desktop: sync mimetypes with those of Sheets, Stage, Words, remove outdated entries)

2013-02-26 Thread Shantanu Tushar Jha
I have mixed feelings when I think about having a touch UI for each of the Calligra apps separately. On one side there are advantages that you mentioned, but then it seems as if there will be too much work and/or duplication. Again, I am not very sure and this definitely looks like sprint discussio

Re: Review Request 109082: Separate files for the app into own subdir "app/" for Stage and Words

2013-02-23 Thread Yue Liu
es from the part/ directory makes the > sources easier to grasp (should also help beginners with Calligra code). And > it also results in having the complete sources for the product "Stage > executable" and "Words executable" in a separate dir structure, so decision &g

Re: Problems with Calligra Active and mimetypes (was: Re: Review Request 108996: update calligraactive.desktop: sync mimetypes with those of Sheets, Stage, Words, remove outdated entries)

2013-02-22 Thread Friedrich W. H. Kossebau
Am Samstag, 23. Februar 2013, 00:00:24 schrieb Friedrich W. H. Kossebau: > Especially with the document-centric design of Calligra Active, where eh, s/Calligra Active/Plasma Active/ here of course :) Friedrich ___ calligra-devel mailing list calligra-d

Problems with Calligra Active and mimetypes (was: Re: Review Request 108996: update calligraactive.desktop: sync mimetypes with those of Sheets, Stage, Words, remove outdated entries)

2013-02-22 Thread Friedrich W. H. Kossebau
Hi Shantanu & all, Am Sonntag, 17. Februar 2013, 17:45:08 schrieb Shantanu Tushar: > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/108996/#review27591 > --

Re: Review Request 109082: Separate files for the app into own subdir "app/" for Stage and Words

2013-02-22 Thread Friedrich W. H. Kossebau
easier to grasp (should also help beginners with Calligra code). And it also results in having the complete sources for the product "Stage executable" and "Words executable" in a separate dir structure, so decision about building it or not is not some if-defed longer span

Re: Review Request 109082: Separate files for the app into own subdir "app/" for Stage and Words

2013-02-22 Thread Boudewijn Rempt
iew request for Calligra, C. Boemann and Thorsten Zachmann. > > > Description > --- > > Splitting out the app-related files from the part/ directory makes the > sources easier to grasp (should also help beginners with Calligra code). And > it also results in having the comple

Re: Review Request 109082: Separate files for the app into own subdir "app/" for Stage and Words

2013-02-22 Thread Inge Wallin
elated files from the part/ directory makes the > sources easier to grasp (should also help beginners with Calligra code). And > it also results in having the complete sources for the product "Stage > executable" and "Words executable" in a separate dir structure, so de

Re: Review Request 109082: Separate files for the app into own subdir "app/" for Stage and Words

2013-02-21 Thread Friedrich W. H. Kossebau
results in having the complete sources for the product "Stage executable" and "Words executable" in a separate dir structure, so decision about building it or not is not some if-defed longer span in a CMakeLists.txt file (of part/), but instead can be done in simply-to-overlook li

Re: Review Request 109082: Separate files for the app into own subdir "app/" for Stage and Words

2013-02-21 Thread Friedrich W. H. Kossebau
nd are we now talking > > different po packages? Ah, good hint, Words just collects messages from part/, missed that, as Stage simply does a grep over everything and has the part ensure the catalog loading. The (only) Words plugin has its own Messages.sh... and is disabled anyway. So

Re: Review Request 109082: Separate files for the app into own subdir "app/" for Stage and Words

2013-02-21 Thread C. Boemann
Boemann and Thorsten Zachmann. > > > Description > --- > > Splitting out the app-related files from the part/ directory makes the > sources easier to grasp (should also help beginners with Calligra code). And > it also results in having the complete sources for the product "St

Re: Review Request 109082: Separate files for the app into own subdir "app/" for Stage and Words

2013-02-21 Thread C. Boemann
Boemann and Thorsten Zachmann. > > > Description > --- > > Splitting out the app-related files from the part/ directory makes the > sources easier to grasp (should also help beginners with Calligra code). And > it also results in having the complete sources for the product "St

Review Request 109082: Separate files for the app into own subdir "app/" for Stage and Words

2013-02-21 Thread Friedrich W. H. Kossebau
. Description --- Splitting out the app-related files from the part/ directory makes the sources easier to grasp (should also help beginners with Calligra code). And it also results in having the complete sources for the product "Stage executable" and "Words executable" in a separa

Re: Review Request 109002: Turning stage into modebox

2013-02-19 Thread C. Boemann
ason for those? because the tool is now defined in kopageapp lib prober, and this is just a plugin. This way Stage is able to work on the tool > On Feb. 18, 2013, 5:47 p.m., Thorsten Zachmann wrote: > > libs/kopageapp/tools/backgroundTool/KoPABackgroundTool.h, line 30 > > <h

Re: Review Request 109002: Turning stage into modebox

2013-02-18 Thread Thorsten Zachmann
/109002/#comment20718> Why is this export needed? libs/kopageapp/tools/backgroundTool/KoPABackgroundToolFactory.cpp <http://git.reviewboard.kde.org/r/109002/#comment20716> As said in the TODO this should use Slide design in Stage and Page design in Flow. - Thorsten Zachman

Re: Review Request 109002: Turning stage into modebox

2013-02-18 Thread Thorsten Zachmann
org/r/109002/ > --- > > (Updated Feb. 18, 2013, 9:14 a.m.) > > > Review request for Calligra and C. Boemann. > > > Description > --- > > Turns stage into modebox. > Totaly remove the Stroke and Fill docker. > Add the background fill widget, especialy n

Review Request 109002: Turning stage into modebox

2013-02-18 Thread Jean-Nicolas Artaud
stage into modebox. Totaly remove the Stroke and Fill docker. Add the background fill widget, especialy needed in stage. Diffs - flow/part/FlowView.cpp b30dbe9 libs/kopageapp/CMakeLists.txt 35db53f libs/kopageapp/KoPAView.h 80b9f78 libs/kopageapp/KoPAView.cpp 58b4940 libs

Re: Review Request 108996: update calligraactive.desktop: sync mimetypes with those of Sheets, Stage, Words, remove outdated entries

2013-02-18 Thread Commit Hook
itself as handler for the same mimetypes as the > "normal" programs Sheets, Stage & Words do, or? > Any osso entries are not expected to be used again. And the x-Window-Icon > also seems outdated Maemo stuff. > > Attached patch removes all those entries considere

Re: Review Request 108996: update calligraactive.desktop: sync mimetypes with those of Sheets, Stage, Words, remove outdated entries

2013-02-17 Thread Commit Hook
handler for the same mimetypes as the > "normal" programs Sheets, Stage & Words do, or? > Any osso entries are not expected to be used again. And the x-Window-Icon > also seems outdated Maemo stuff. > > Attached patch removes all those entries considered outdated and

Re: Review Request 108996: update calligraactive.desktop: sync mimetypes with those of Sheets, Stage, Words, remove outdated entries

2013-02-17 Thread Shantanu Tushar
and Shantanu Tushar. > > > Description > --- > > CalligraActive should offer itself as handler for the same mimetypes as the > "normal" programs Sheets, Stage & Words do, or? > Any osso entries are not expected to be used again. And the x-Window-Icon > also see

Review Request 108996: update calligraactive.desktop: sync mimetypes with those of Sheets, Stage, Words, remove outdated entries

2013-02-17 Thread Friedrich W. H. Kossebau
--- CalligraActive should offer itself as handler for the same mimetypes as the "normal" programs Sheets, Stage & Words do, or? Any osso entries are not expected to be used again. And the x-Window-Icon also seems outdated Maemo stuff. Attached patch removes all those entries considere

Note: upcoming RR for KoOdfWriteStore handling the manifest creation automatically (was: Re: [calligra] filters/stage/kpr2odf: Do not write a manifest entry for the "Thumbnails" directory in Filterkpr

2013-01-08 Thread Friedrich W. H. Kossebau
Am Montag, 7. Januar 2013, 05:27:36 schrieb Inge Wallin: > On Sunday, January 06, 2013 18:55:07 Friedrich W. H. Kossebau wrote: > > Git commit 3bd6df2332edb1d3a18e853deaf255c874b144c9 by Friedrich W. H. > > Kossebau. Committed on 06/01/2013 at 18:54. > > Pushed by kossebau into branch 'master'. > >

Re: [calligra/calligra/2.6] /: Use new app icon names in Flow, Sheets, Stage, Words

2013-01-06 Thread Friedrich W. H. Kossebau
Am Sonntag, 6. Januar 2013, 17:45:38 schrieb Friedrich W. H. Kossebau: > Git commit 02d5958dc4e4bccee063772a8bf929baee840e99 by Friedrich W. H. > Kossebau. Committed on 06/01/2013 at 17:45. > Pushed by kossebau into branch 'calligra/2.6'. > > Use new app icon names in F

Re: Review Request: Flow, Karbon, Stage and Sheets: use the currently set size units in the pagelayout dialog

2013-01-06 Thread Commit Hook
t: > http://git.reviewboard.kde.org/r/108221/ > --- > > (Updated Jan. 6, 2013, 4:11 a.m.) > > > Review request for Calligra. > > > Description > --- > > Words does it, but Flow, Karbon, Stage and Sheets d

Re: Review Request: Flow, Karbon, Stage and Sheets: use the currently set size units in the pagelayout dialog

2013-01-06 Thread Commit Hook
t: > http://git.reviewboard.kde.org/r/108221/ > --- > > (Updated Jan. 6, 2013, 4:11 a.m.) > > > Review request for Calligra. > > > Description > --- > > Words does it, but Flow, Karbon, Stage and Sheets don't:

Re: Review Request: Flow, Karbon, Stage and Sheets: use the currently set size units in the pagelayout dialog

2013-01-05 Thread Inge Wallin
org/r/108221/ > --- > > (Updated Jan. 6, 2013, 4:11 a.m.) > > > Review request for Calligra. > > > Description > --- > > Words does it, but Flow, Karbon, Stage and Sheets don't: use the currently > set size units in the pagelayout dialog. >

Review Request: Flow, Karbon, Stage and Sheets: use the currently set size units in the pagelayout dialog

2013-01-05 Thread Friedrich W. H. Kossebau
, Karbon, Stage and Sheets don't: use the currently set size units in the pagelayout dialog. Attached patch fixes that. Okay to backport to 2.6? This addresses bug 312690. http://bugs.kde.org/show_bug.cgi?id=312690 Diffs - karbon/ui/KarbonView.cpp 6f8bf72 libs/kopageapp/di

Re: Review Request: fix bad offset of cursor markers in rulers if document is smaller than canvas (Stage/Flow)

2012-10-31 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106405/#review21197 --- This review has been submitted with commit 513ad983e1e43399b90

Re: Review Request: Change Stage and Flow to have infinite type canvas

2012-10-13 Thread Yue Liu
To reply, visit: > http://git.reviewboard.kde.org/r/104928/ > --- > > (Updated May 17, 2012, 7:14 p.m.) > > > Review request for Calligra. > > > Description > --- > > KoPageApp applications Stage and Flow used to

Re: Review Request: fix bad offset of cursor markers in rulers if document is smaller than canvas (Stage/Flow)

2012-10-07 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106405/#review20036 --- This review has been submitted with commit b9977978411d9b432a7

Re: Review Request: fix bad offset of cursor markers in rulers if document is smaller than canvas (Stage/Flow)

2012-10-05 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106405/#review19959 --- This review has been submitted with commit f6ef9c4a54effee07f1

Re: Review Request: fix bad offset of cursor markers in rulers if document is smaller than canvas (Stage/Flow)

2012-09-10 Thread Friedrich W. H. Kossebau
guess, I just cannot remember to have seen this bug before around that time. All I know is that the fix works, for Stage/Flow (and that I have no idea how to fix Krita, due to the API contract breakage). - Friedrich W. H. --- This i

Re: Review Request: fix bad offset of cursor markers in rulers if document is smaller than canvas (Stage/Flow)

2012-09-10 Thread Boudewijn Rempt
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106405/#review18798 --- Which recent infinite canvas? Shrikrishna hasn't merged his wor

Review Request: fix bad offset of cursor markers in rulers if document is smaller than canvas (Stage/Flow)

2012-09-09 Thread Friedrich W. H. Kossebau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106405/ --- Review request for Calligra, Yue Liu and Thorsten Zachmann. Description --

Localization of Animation tool in Stage

2012-09-02 Thread Yuri Chornoivan
Hi! Many thanks for Animation tool that was added to Stage. It looks very nice and works very good. Just two comments on its localization. 1. Is it possible to make "seconds" (KPrTimeLineHeader.cpp:70: paintHeaderItem(painter, rect, QString("seconds"));) translatabl

Re: Review Request: GSoC: Stage: Shape animations docker with no editable information (yet) and shape animations preview

2012-07-06 Thread C. Boemann
emented) > > Add a model to manage animations data information > Extend shapeAnimation class in order to save presentation-preset tags with > information of animation type (entrance, exit, etc) and name. > > The patch is only for a GSoC progress Review. Though being usable

Re: Review Request: fixes thumbnails of KoPADocuments to be without empty spaces around (Flow, Stage)

2012-07-02 Thread Commit Hook
5f4 > libs/kopageapp/KoPAPageBase.h b9a5961 > libs/kopageapp/KoPAPageBase.cpp cd25030 > libs/kopageapp/KoPAUtil.h b4ac6c4 > libs/kopageapp/KoPAUtil.cpp 5353151 > stage/part/KPrNotes.h 28ee984 > > Diff: http://git.reviewboard.kde.org/r/105390/diff/ > > > T

Re: Review Request: fixes thumbnails of KoPADocuments to be without empty spaces around (Flow, Stage)

2012-07-02 Thread Commit Hook
libs/kopageapp/KoPAPageBase.h b9a5961 > libs/kopageapp/KoPAPageBase.cpp cd25030 > libs/kopageapp/KoPAUtil.h b4ac6c4 > libs/kopageapp/KoPAUtil.cpp 5353151 > stage/part/KPrNotes.h 28ee984 > > Diff: http://git.reviewboard.kde.org/r/105390/diff/ > > > Testing >

  1   2   3   4   >