Re: Review Request 123833: Krita: Add basic modifier key support to selection tools.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123833/ --- (Updated June 21, 2015, 1:51 p.m.) Status -- This change has been ma

Re: Review Request 123833: Krita: Add basic modifier key support to selection tools.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123833/#review81616 --- Ship it! Ship It! - Boudewijn Rempt On June 20, 2015, 10:1

Re: Review Request 123833: Krita: Add basic modifier key support to selection tools.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123833/ --- (Updated June 20, 2015, 10:16 p.m.) Review request for Calligra. Change

Re: Review Request 123833: Krita: Add basic modifier key support to selection tools.

> On June 19, 2015, 9:07 p.m., Boudewijn Rempt wrote: > > Okay, awesome! Let's test it again :-) Aw... Build fails here... - Boudewijn --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123

Re: Review Request 123833: Krita: Add basic modifier key support to selection tools.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123833/#review81576 --- Okay, awesome! Let's test it again :-) - Boudewijn Rempt On

Re: Review Request 123833: Krita: Add basic modifier key support to selection tools.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123833/ --- (Updated June 19, 2015, 8:55 p.m.) Review request for Calligra. Changes

Re: Review Request 123833: Krita: Add basic modifier key support to selection tools.

> On June 2, 2015, 7:39 a.m., Boudewijn Rempt wrote: > > For the record: https://bugs.kde.org/show_bug.cgi?id=348234 is where we're > > tracking the issues with this patch. It's looking good, but there are still > > a few! Ping? Did you have time to check the the report? I'd love for this patc

Re: Review Request 123833: Krita: Add basic modifier key support to selection tools.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123833/#review81066 --- For the record: https://bugs.kde.org/show_bug.cgi?id=348234 is

Re: Review Request 123833: Krita: Add basic modifier key support to selection tools.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123833/ --- (Updated May 26, 2015, 8:47 a.m.) Status -- This change has been mar

Re: Review Request 123833: Krita: Add basic modifier key support to selection tools.

> On May 25, 2015, 8:45 a.m., Dmitry Kazakov wrote: > > krita/ui/input/kis_alternate_invocation_action.cpp, line 45 > > > > > > Hi, Michael! > > > > Could you remove "Alternate" word from these strings? I

Re: Review Request 123833: Krita: Add basic modifier key support to selection tools.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123833/#review80797 --- Awesome! Almost everything works now, except for the bezier se

Re: Review Request 123833: Krita: Add basic modifier key support to selection tools.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123833/#review80792 --- krita/ui/input/kis_alternate_invocation_action.cpp (line 45)

Re: Review Request 123833: Krita: Add basic modifier key support to selection tools.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123833/ --- (Updated May 25, 2015, 1:57 a.m.) Review request for Calligra. Changes

Re: Review Request 123833: Krita: Add basic modifier key support to selection tools.

> On May 19, 2015, 10:15 a.m., Boudewijn Rempt wrote: > > krita/ui/input/kis_alternate_invocation_action.cpp, line 43 > > > > > > These renames seem to be problematic, we need to get rid of the > > "Alternate" in

Re: Review Request 123833: Krita: Add basic modifier key support to selection tools.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123833/ --- (Updated May 25, 2015, 1:38 a.m.) Review request for Calligra. Changes

Re: Review Request 123833: Krita: Add basic modifier key support to selection tools.

> On May 19, 2015, 10:15 a.m., Boudewijn Rempt wrote: > > krita/ui/input/kis_alternate_invocation_action.cpp, line 43 > > > > > > These renames seem to be problematic, we need to get rid of the > > "Alternate" in

Re: Review Request 123833: Krita: Add basic modifier key support to selection tools.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123833/#review80619 --- krita/ui/input/kis_alternate_invocation_action.cpp (line 43)

Re: Review Request 123833: Krita: Add basic modifier key support to selection tools.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123833/#review80616 --- Hm, I was a bit hasty. The basic tools worked so nicely that I

Re: Review Request 123833: Krita: Add basic modifier key support to selection tools.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123833/ --- (Updated May 18, 2015, 8:33 a.m.) Status -- This change has been mar

Re: Review Request 123833: Krita: Add basic modifier key support to selection tools.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123833/#review80560 --- Ship it! Apart from the small issues I just found, and which

Re: Review Request 123833: Krita: Add basic modifier key support to selection tools.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123833/#review80559 --- krita/ui/tool/kis_selection_action_template.h (line 1)

Re: Review Request 123833: Krita: Add basic modifier key support to selection tools.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123833/ --- (Updated May 17, 2015, 9:20 p.m.) Review request for Calligra. Summary