Re: Review Request 122278: Additional changes in section handling

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122278/ --- (Updated Фев. 1, 2015, 1:01 п.п.) Status -- This change has been mar

Re: Review Request 122278: Additional changes in section handling

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122278/#review75077 --- Ship it! Ship It! - Camilla Boemann On Jan. 31, 2015, 4:14

Re: Review Request 122278: Additional changes in section handling

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122278/ --- (Updated Янв. 31, 2015, 4:14 п.п.) Review request for Calligra, Camilla B

Re: Review Request 122278: Additional changes in section handling

> On Jan. 27, 2015, 7:34 p.m., Camilla Boemann wrote: > > libs/kotext/commands/DeleteCommand.cpp, line 321 > > > > > > yikes > > Denis Kuplyakov wrote: > QVariant before was used like static_cast(v.value()).

Re: Review Request 122278: Additional changes in section handling

> On Янв. 27, 2015, 7:34 п.п., Camilla Boemann wrote: > > libs/kotext/KoSectionManager.cpp, line 120 > > > > > > why no long const ? > > Denis Kuplyakov wrote: > I don't know why, but QHash::find() isn't con

Re: Review Request 122278: Additional changes in section handling

> On Jan. 27, 2015, 7:34 p.m., Camilla Boemann wrote: > > libs/kotext/KoSectionManager.cpp, line 120 > > > > > > why no long const ? > > Denis Kuplyakov wrote: > I don't know why, but QHash::find() isn't con

Re: Review Request 122278: Additional changes in section handling

On Thursday, January 29, 2015 14:11:39 Inge Wallin wrote: > On Thursday, January 29, 2015 12:57:35 Denis Kuplyakov wrote: > > > On Янв. 27, 2015, 7:34 п.п., Camilla Boemann wrote: > > > > libs/kotext/KoSectionManager.cpp, line 120 > > > >

Re: Review Request 122278: Additional changes in section handling

On Thursday, January 29, 2015 12:57:35 Denis Kuplyakov wrote: > > On Янв. 27, 2015, 7:34 п.п., Camilla Boemann wrote: > > > libs/kotext/KoSectionManager.cpp, line 120 > > > > > line120>> > > > > why no long const ? > >

Re: Review Request 122278: Additional changes in section handling

> On Янв. 27, 2015, 7:34 п.п., Camilla Boemann wrote: > > libs/kotext/KoSectionManager.cpp, line 120 > > > > > > why no long const ? > > Denis Kuplyakov wrote: > I don't know why, but QHash::find() isn't con

Re: Review Request 122278: Additional changes in section handling

> On Jan. 27, 2015, 7:34 p.m., Camilla Boemann wrote: > > libs/kotext/commands/DeleteCommand.cpp, line 321 > > > > > > yikes > > Denis Kuplyakov wrote: > QVariant before was used like static_cast(v.value()).

Re: Review Request 122278: Additional changes in section handling

> On Jan. 27, 2015, 7:34 p.m., Camilla Boemann wrote: > > libs/kotext/KoSectionManager.cpp, line 120 > > > > > > why no long const ? > > Denis Kuplyakov wrote: > I don't know why, but QHash::find() isn't con

Re: Review Request 122278: Additional changes in section handling

> On Янв. 27, 2015, 7:34 п.п., Camilla Boemann wrote: > > libs/kotext/KoSectionManager.cpp, line 120 > > > > > > why no long const ? > > Denis Kuplyakov wrote: > I don't know why, but QHash::find() isn't con

Re: Review Request 122278: Additional changes in section handling

> On jan 27, 2015, 7:34 e.m., Camilla Boemann wrote: > > libs/kotext/KoSectionManager.cpp, line 120 > > > > > > why no long const ? > > Denis Kuplyakov wrote: > I don't know why, but QHash::find() isn't cons

Re: Review Request 122278: Additional changes in section handling

> On Jan. 27, 2015, 7:34 p.m., Camilla Boemann wrote: > > libs/kotext/KoSectionManager.cpp, line 120 > > > > > > why no long const ? > > Denis Kuplyakov wrote: > I don't know why, but QHash::find() isn't con

Re: Review Request 122278: Additional changes in section handling

> On Янв. 27, 2015, 7:34 п.п., Camilla Boemann wrote: > > libs/kotext/KoSectionManager.cpp, line 120 > > > > > > why no long const ? > > Denis Kuplyakov wrote: > I don't know why, but QHash::find() isn't con

Re: Review Request 122278: Additional changes in section handling

> On Jan. 27, 2015, 7:34 p.m., Camilla Boemann wrote: > > libs/kotext/KoSectionManager.cpp, line 120 > > > > > > why no long const ? > > Denis Kuplyakov wrote: > I don't know why, but QHash::find() isn't con

Re: Review Request 122278: Additional changes in section handling

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122278/ --- (Updated Янв. 28, 2015, 8:21 п.п.) Review request for Calligra, Camilla B

Re: Review Request 122278: Additional changes in section handling

> On Янв. 27, 2015, 7:34 п.п., Camilla Boemann wrote: > > libs/kotext/KoSectionManager.cpp, line 120 > > > > > > why no long const ? > > Denis Kuplyakov wrote: > I don't know why, but QHash::find() isn't con

Re: Review Request 122278: Additional changes in section handling

> On Янв. 27, 2015, 7:34 п.п., Camilla Boemann wrote: > > libs/kotext/KoSectionManager.cpp, line 120 > > > > > > why no long const ? > > Denis Kuplyakov wrote: > I don't know why, but QHash::find() isn't con

Re: Review Request 122278: Additional changes in section handling

> On Янв. 27, 2015, 7:34 п.п., Camilla Boemann wrote: > > libs/kotext/KoSectionManager.cpp, line 120 > > > > > > why no long const ? I don't know why, but QHash::find() isn't const. Thats why I can't make this

Re: Review Request 122278: Additional changes in section handling

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122278/#review74840 --- lots of spaces that needs to be fixed libs/kotext/KoSectionM

Review Request 122278: Additional changes in section handling

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122278/ --- Review request for Calligra, Camilla Boemann and Inge Wallin. Repository: