Re: Review Request 120733: Pass more data between layout and RootAreaProvider

On Saturday, December 06, 2014 07:11:04 PM Dan Leinir Turthra Jensen wrote: > This is, i know, somewhat late in the review phase, but i expect it's a > smallish issue anyway. In short, 4fa0b6e29d31d7755441b231ea3bf2ef068435b4 > breaks text input in Stage. Which i discovered while setting out to mak

Re: Review Request 120733: Pass more data between layout and RootAreaProvider

This is, i know, somewhat late in the review phase, but i expect it's a smallish issue anyway. In short, 4fa0b6e29d31d7755441b231ea3bf2ef068435b4 breaks text input in Stage. Which i discovered while setting out to make a presentation i've got to give on Monday ;) On Wednesday 22 Oct 2014 21:44:

Re: Review Request 120733: Pass more data between layout and RootAreaProvider

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120733/ --- (Updated Nov. 27, 2014, 10 p.m.) Status -- This change has been mark

Re: Review Request 120733: Pass more data between layout and RootAreaProvider

> On nov 27, 2014, 9:14 e.m., Camilla Boemann wrote: > > libs/textlayout/KoTextDocumentLayout.cpp, line 858 > > > > > > but doing nothing and not incrmenting ?? either this objection is too complex for me to u

Re: Review Request 120733: Pass more data between layout and RootAreaProvider

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120733/#review71040 --- Ship it! Ship It! - Camilla Boemann On Nov. 27, 2014, 9:05

Re: Review Request 120733: Pass more data between layout and RootAreaProvider

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120733/#review71039 --- libs/textlayout/KoTextDocumentLayout.cpp

Re: Review Request 120733: Pass more data between layout and RootAreaProvider

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120733/ --- (Updated Nov. 27, 2014, 10:05 p.m.) Review request for Calligra and Camil

Re: Review Request 120733: Pass more data between layout and RootAreaProvider

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120733/#review71003 --- libs/textlayout/KoTextDocumentLayout.cpp

Re: Review Request 120733: Pass more data between layout and RootAreaProvider

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120733/ --- (Updated Nov. 26, 2014, 11:08 p.m.) Review request for Calligra and Camil

Re: Review Request 120733: Pass more data between layout and RootAreaProvider

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120733/ --- (Updated Nov. 19, 2014, 9:39 a.m.) Review request for Calligra and Camill

Re: Review Request 120733: Pass more data between layout and RootAreaProvider

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120733/#review70051 --- hmm while theis flowlayout might work now, it doesnt work for

Re: Review Request 120733: Pass more data between layout and RootAreaProvider

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120733/ --- (Updated Nov. 8, 2014, 1:20 p.m.) Review request for Calligra and Camilla

Re: Review Request 120733: Pass more data between layout and RootAreaProvider

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120733/#review70025 --- libs/textlayout/KoTextDocumentLayout.cpp

Re: Review Request 120733: Pass more data between layout and RootAreaProvider

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120733/ --- (Updated Nov. 8, 2014, 12:38 a.m.) Review request for Calligra and Camill

Re: Review Request 120733: Pass more data between layout and RootAreaProvider

> On Oct. 30, 2014, 10 p.m., Camilla Boemann wrote: > > Okay I have had time to look it through and i like how you have merged the > > two chunks of very similar code > > > > Very good work > > > > I only have one small apidox request plus I hope you have run cs tester on > > this, and otherw

Re: Review Request 120733: Pass more data between layout and RootAreaProvider

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120733/#review69557 --- Okay I have had time to look it through and i like how you hav

Re: Review Request 120733: Pass more data between layout and RootAreaProvider

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120733/ --- (Updated Oct. 28, 2014, 8:29 a.m.) Review request for Calligra and Camill

Re: Review Request 120733: Pass more data between layout and RootAreaProvider

> On Oct. 23, 2014, 7:28 a.m., Camilla Boemann wrote: > > words/part/KWRootAreaProvider.cpp, line 168 > > > > > > i guess we should insert a page instead of appending (thus avoiding the > > need to release all a

Re: Review Request 120733: Pass more data between layout and RootAreaProvider

> On Oct. 23, 2014, 7:28 a.m., Camilla Boemann wrote: > > I like the idea of the constraints, and how you fill it > > > > but i am not so sure about the doLayout() testing and acting on the > > constraints. I feel this belong in the provider if at all possible > > > > And encountering a differ

Re: Review Request 120733: Pass more data between layout and RootAreaProvider

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120733/#review68957 --- I like the idea of the constraints, and how you fill it but i

Re: Review Request 120733: Pass more data between layout and RootAreaProvider

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120733/ --- (Updated Oct. 23, 2014, 7:15 a.m.) Review request for Calligra and Camill

Review Request 120733: Pass more data between layout and RootAreaProvider

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120733/ --- Review request for Calligra and Camilla Boemann. Repository: calligra D