Re: Review Request 120505: Adding a activation-toggle and preview to assistants.

2014-10-16 Thread Wolthera van Hövell
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120505/ --- (Updated Oct. 16, 2014, 8:32 p.m.) Status -- This change has been ma

Re: Review Request 120505: Adding a activation-toggle and preview to assistants.

2014-10-15 Thread Boudewijn Rempt
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120505/#review68493 --- Ship it! I think it's good to go at this stage (just remove t

Re: Review Request 120505: Adding a activation-toggle and preview to assistants.

2014-10-11 Thread Wolthera van Hövell
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120505/ --- (Updated Oct. 11, 2014, 11:26 a.m.) Review request for Calligra, Dmitry K

Re: Review Request 120505: Adding a activation-toggle and preview to assistants.

2014-10-10 Thread Scott Petrovic
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120505/#review68246 --- I made a couple comments on the forum about improving the UI

Re: Review Request 120505: Adding a activation-toggle and preview to assistants.

2014-10-10 Thread Sven Langkamp
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120505/#review68238 --- krita/plugins/assistants/RulerAssistant/PerspectiveAssistant.

Re: Review Request 120505: Adding a activation-toggle and preview to assistants.

2014-10-10 Thread Wolthera van Hövell
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120505/ --- (Updated Oct. 10, 2014, 9:32 p.m.) Review request for Calligra, Dmitry Ka

Re: Review Request 120505: Adding a activation-toggle and preview to assistants.

2014-10-10 Thread Wolthera van Hövell
> On Oct. 10, 2014, 8:13 p.m., Sven Langkamp wrote: > > KisPaintingAssistantsDecoration is a KisCanvasDecoration which already has > > setVisible and toggleVisible. It's not needed to do the > > setAssistantVisible, I think. Yes indeed, it does. However, if we use that, it won't allow me to pa

Re: Review Request 120505: Adding a activation-toggle and preview to assistants.

2014-10-10 Thread Sven Langkamp
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120505/#review68228 --- KisPaintingAssistantsDecoration is a KisCanvasDecoration which

Re: Review Request 120505: Adding a activation-toggle and preview to assistants.

2014-10-10 Thread Wolthera van Hövell
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120505/ --- (Updated Oct. 10, 2014, 7:06 p.m.) Review request for Calligra, Dmitry Ka

Re: Review Request 120505: Adding a activation-toggle and preview to assistants.

2014-10-10 Thread Wolthera van Hövell
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120505/ --- (Updated Oct. 10, 2014, 1:13 p.m.) Status -- This change has been ma

Review Request 120505: Adding a activation-toggle and preview to assistants.

2014-10-05 Thread Wolthera van Hövell
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120505/ --- Review request for Calligra, Dmitry Kazakov and Boudewijn Rempt. Reposito