Re: Review Request 118519: Fix crash when accessing a query with duplicated table names

2014-06-05 Thread Jarosław Staniek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118519/ --- (Updated June 5, 2014, 7:49 p.m.) Status -- This change has been mar

Re: Review Request 118519: Fix crash when accessing a query with duplicated table names

2014-06-05 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118519/#review59356 --- This review has been submitted with commit f8f807ebd94d9f9596

Re: Review Request 118519: Fix crash when accessing a query with duplicated table names

2014-06-05 Thread Adam Pigg
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118519/#review59355 --- Ship it! Added test cases and passes with patch applied - Ad

Re: Review Request 118519: Fix crash when accessing a query with duplicated table names

2014-06-04 Thread Jarosław Staniek
> On June 4, 2014, 9:08 p.m., Adam Pigg wrote: > > I was wonderingthis seems like it would suit a unit-test. I know we > > arent set up for unit-test yet but we could start somewhere. 2 tests could > > show a valid query passing, and an incorrect query returning the > > appropriate failu

Re: Review Request 118519: Fix crash when accessing a query with duplicated table names

2014-06-04 Thread Adam Pigg
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118519/#review59245 --- I was wonderingthis seems like it would suit a unit-test.

Review Request 118519: Fix crash when accessing a query with duplicated table names

2014-06-04 Thread Jarosław Staniek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118519/ --- Review request for Calligra, Andrius da Costa Ribas, Oleg Kukharchuk, Adam