Re: Review Request 117803: Update list of reserved keywords for sqlite in Kexi

> On May 9, 2014, 9:52 p.m., Jarosław Staniek wrote: > > It appears that this review should have title like "Added toUpper for a > > word to be checked if is KexiSql keyword" as it's bound to commit > > de07f92717012158b83ca0 to master. Please update to avoid confusion. > > > > Also you forgo

Re: Review Request 117803: Update list of reserved keywords for sqlite in Kexi

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117803/#review57653 --- It appears that this review should have title like "Added toUp

Re: Review Request 117803: Update list of reserved keywords for sqlite in Kexi

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117803/ --- (Updated May 2, 2014, 11:43 p.m.) Status -- This change has been mar

Re: Review Request 117803: Update list of reserved keywords for sqlite in Kexi

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117803/#review57166 --- "status changed from submitted to pending" - hmm, I guess you

Re: Review Request 117803: Update list of reserved keywords for sqlite in Kexi

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117803/ --- (Updated May 1, 2014, 11:46 p.m.) Status -- This change has been mar

Re: Review Request 117803: Update list of reserved keywords for sqlite in Kexi

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117803/#review57091 --- This review has been submitted with commit de07f92717012158b8

Re: Review Request 117803: Update list of reserved keywords for sqlite in Kexi

> On May 1, 2014, 10:53 p.m., Jarosław Staniek wrote: > > Good catch, Wojtek! > > > > As we can see StaticSetOfStrings is used for optimization (it offers zero > > mem copy). > > > > Summing up, I think 5 separate commits would be ideal: > > 1, 2, 3: update the lists of keywords (for 3 db eng

Re: Review Request 117803: Update list of reserved keywords for sqlite in Kexi

> On May 1, 2014, 10:53 p.m., Jarosław Staniek wrote: > > Good catch, Wojtek! > > > > As we can see StaticSetOfStrings is used for optimization (it offers zero > > mem copy). > > > > Summing up, I think 5 separate commits would be ideal: > > 1, 2, 3: update the lists of keywords (for 3 db eng

Re: Review Request 117803: Update list of reserved keywords for sqlite in Kexi

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117803/#review57087 --- Good catch, Wojtek! As we can see StaticSetOfStrings is used

Re: Review Request 117803: Update list of reserved keywords for sqlite in Kexi

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117803/ --- (Updated May 1, 2014, 10:40 p.m.) Review request for Calligra and Jarosła

Re: Review Request 117803: Update list of reserved keywords for sqlite in Kexi

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117803/ --- (Updated May 1, 2014, 10:33 p.m.) Review request for Calligra and Jarosła

Re: Review Request 117803: Update list of reserved keywords for sqlite in Kexi

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117803/#review56717 --- libs/db/drivers/sqlite/sqlitekeywords.cpp

Re: Review Request 117803: Update list of reserved keywords for sqlite in Kexi

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117803/ --- (Updated April 27, 2014, 7:32 p.m.) Review request for Calligra and Jaros