Re: Review Request 111560: Use QStringBuilder

2013-07-18 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111560/ --- (Updated July 18, 2013, 4:27 p.m.) Status -- This change has been mar

Re: Review Request 111560: Use QStringBuilder

2013-07-18 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111560/#review36134 --- This review has been submitted with commit b48249b5010ce824f1d

Re: Review Request 111560: Use QStringBuilder

2013-07-18 Thread Friedrich W. H. Kossebau
> On July 18, 2013, 4:13 p.m., Boudewijn Rempt wrote: > > Ship It! Ah, just pushed a branch for people testing it, calligra-useQStringBuilder-kossebau :) Alright, will merge this commit anyway, that branch also has the second patch in I was talking about before, so still might make sense to t

Re: Review Request 111560: Use QStringBuilder

2013-07-18 Thread Boudewijn Rempt
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111560/#review36132 --- Ship it! Ship It! - Boudewijn Rempt On July 18, 2013, 10:25

Re: Review Request 111560: Use QStringBuilder

2013-07-18 Thread Friedrich W. H. Kossebau
> On July 18, 2013, 10:39 a.m., Boudewijn Rempt wrote: > > Hm, I don't know... I doubt it actually makes a difference in most if not > > all of the cases -- for instance, changing the way a string is constructed > > for a dialog will not make the dialog pop up perceptibly faster, and I see > >

Re: Review Request 111560: Use QStringBuilder

2013-07-18 Thread Boudewijn Rempt
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111560/#review36103 --- Hm, I don't know... I doubt it actually makes a difference in m

Review Request 111560: Use QStringBuilder

2013-07-18 Thread Friedrich W. H. Kossebau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111560/ --- Review request for Calligra. Description --- There are lots of string