Re: Review Request 110506: Ignore application of default styles in DockerStylesComboModel

2013-05-27 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110506/#review33221 --- This review has been submitted with commit 21d4b1f97167e4974c4

Re: Review Request 110506: Ignore application of default styles in DockerStylesComboModel

2013-05-27 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110506/ --- (Updated May 27, 2013, 2:15 p.m.) Status -- This change has been mark

Re: Review Request 110506: Ignore application of default styles in DockerStylesComboModel

2013-05-27 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110506/#review33205 --- Ship it! Ok it looks sane enough to me so let's take the chanc

Re: Review Request 110506: Ignore application of default styles in DockerStylesComboModel

2013-05-21 Thread Elvis Stansvik
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110506/#review32944 --- Since Camilla reminded me that the styles models et.c. are bein

Re: Review Request 110506: Ignore application of default styles in DockerStylesComboModel

2013-05-19 Thread Elvis Stansvik
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110506/ --- (Updated May 19, 2013, 9:44 a.m.) Review request for Calligra and Pierre S

Re: Review Request 110506: Ignore application of default styles in DockerStylesComboModel

2013-05-18 Thread C. Boemann
> On May 19, 2013, 4:36 a.m., Thorsten Zachmann wrote: > > plugins/textshape/dialogs/DockerStylesComboModel.cpp, lines 156-159 > > > > > > I'm not 100% sure but I think the test for the stylesType is not needed >

Re: Review Request 110506: Ignore application of default styles in DockerStylesComboModel

2013-05-18 Thread Thorsten Zachmann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110506/#review32766 --- Good catch. Patch looks good to me. However I would like to get

Review Request 110506: Ignore application of default styles in DockerStylesComboModel

2013-05-18 Thread Elvis Stansvik
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110506/ --- Review request for Calligra and Pierre Stirnweiss. Description --- Du