Re: Review Request: Updating the test case for numfile in TestInformationFunctions

2012-11-27 Thread Marijn Kruisselbrink
> On Nov. 26, 2012, 6:51 p.m., Thorsten Zachmann wrote: > > sheets/functions/information.cpp, lines 193-201 > > > > > > This seems to be wrong. It should return the number of of documents in > > the vlaue and not t

Re: Review Request: Updating the test case for numfile in TestInformationFunctions

2012-11-26 Thread Boudewijn Rempt
On Monday 26 November 2012 Nov, Thorsten Zachmann wrote: > On Monday 26 November 2012 19:52:33 Boudewijn Rempt wrote: > > if (type == "numfile") > > return Value(KoDocument::documentList() ? > > KoDocument::documentList()->count() : 0); > > This is a number and not a bool > > Thorsten

Re: Review Request: Updating the test case for numfile in TestInformationFunctions

2012-11-26 Thread Thorsten Zachmann
On Monday 26 November 2012 19:52:33 Boudewijn Rempt wrote: > if (type == "numfile") > return Value(KoDocument::documentList() ? > KoDocument::documentList()->count() : 0); This is a number and not a bool Thorsten ___ calligra-devel mailing l

Re: Review Request: Updating the test case for numfile in TestInformationFunctions

2012-11-26 Thread Boudewijn Rempt
> On Nov. 26, 2012, 6:51 p.m., Thorsten Zachmann wrote: > > sheets/functions/information.cpp, lines 193-201 > > > > > > This seems to be wrong. It should return the number of of documents in > > the vlaue and not t

Re: Review Request: Updating the test case for numfile in TestInformationFunctions

2012-11-26 Thread Thorsten Zachmann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107459/#review22589 --- libs/main/KoApplication.cpp

Re: Review Request: Updating the test case for numfile in TestInformationFunctions

2012-11-25 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107459/#review22537 --- This review has been submitted with commit 3beb7ee26781e5fd80b

Re: Review Request: Updating the test case for numfile in TestInformationFunctions

2012-11-25 Thread Boudewijn Rempt
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107459/#review22531 --- Ship it! Good work, imo! libs/main/KoApplication.h

Re: Review Request: Updating the test case for numfile in TestInformationFunctions

2012-11-25 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107459/#review22513 --- It looks like a very nice and futureproof approach - C. Boeman

Review Request: Updating the test case for numfile in TestInformationFunctions

2012-11-25 Thread Sujith Haridasan
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107459/ --- Review request for Calligra, Arjen Hiemstra, Boudewijn Rempt, Inge Wallin, a