Re: Review Request: Undo redo framework for text refactored

2012-02-25 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104047/#review10894 --- Ship it! I'm approving it, since it is just as much pierrest's

Re: Review Request: Undo redo framework for text refactored

2012-02-24 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104047/ --- (Updated Feb. 24, 2012, 12:32 p.m.) Review request for Calligra. Changes

Re: Review Request: Undo redo framework for text refactored

2012-02-24 Thread C. Boemann
> On Feb. 24, 2012, 11:58 a.m., Thorsten Zachmann wrote: > > libs/kotext/KoTextEditor.cpp, lines 1891-1900 > > > > > > This code block is duplicated quite often. I think it makes sense to > > re-factor this so it

Re: Review Request: Undo redo framework for text refactored

2012-02-24 Thread Thorsten Zachmann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104047/#review10863 --- The works looks quite good. Some comments. I did not test the c

Review Request: Undo redo framework for text refactored

2012-02-23 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104047/ --- Review request for Calligra. Description --- We have made changes to