Re: Review Request: Port tables plugin to QUndo/kundo2

2012-09-01 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105366/#review18406 --- This review has been submitted with commit ee6d9a744aa88af0684

Re: Review Request: Port tables plugin to QUndo/kundo2

2012-08-23 Thread Jarosław Staniek
> On Aug. 22, 2012, 10:07 p.m., Jarosław Staniek wrote: > > We could not provide visible undo/redo actions in table designer because > > simple (but working) altering will require instant saving. This makes > > undo/redo behaving unexpectedly. That said, your patch is useful in terms > > of po

Re: Review Request: Port tables plugin to QUndo/kundo2

2012-08-23 Thread Adam Pigg
> On Aug. 22, 2012, 10:07 p.m., Jarosław Staniek wrote: > > We could not provide visible undo/redo actions in table designer because > > simple (but working) altering will require instant saving. This makes > > undo/redo behaving unexpectedly. That said, your patch is useful in terms > > of po

Re: Review Request: Port tables plugin to QUndo/kundo2

2012-08-22 Thread Jarosław Staniek
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105366/#review17885 --- Ship it! We could not provide visible undo/redo actions in tab

Re: Review Request: Port tables plugin to QUndo/kundo2

2012-07-02 Thread Adam Pigg
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105366/ --- (Updated July 2, 2012, 8:47 p.m.) Review request for Calligra and Jarosław

Re: Review Request: Port tables plugin to QUndo/kundo2

2012-07-02 Thread Jarosław Staniek
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105366/#review15321 --- OK, so far everything is right, just the missing bits marked wi

Re: Review Request: Port tables plugin to QUndo/kundo2

2012-07-02 Thread Adam Pigg
> On July 2, 2012, 8:04 p.m., Jarosław Staniek wrote: > > kexi/plugins/tables/kexitabledesignerview.cpp, line 1130 > > > > > > why is this line removed? Because it is not needed. In the lines above, the setPrimar

Re: Review Request: Port tables plugin to QUndo/kundo2

2012-07-02 Thread Jarosław Staniek
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105366/#review15318 --- kexi/plugins/tables/kexitabledesignerview.cpp

Re: Review Request: Port tables plugin to QUndo/kundo2

2012-07-02 Thread Adam Pigg
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105366/ --- (Updated July 2, 2012, 7:42 p.m.) Review request for Calligra and Jarosław

Re: Review Request: Port tables plugin to QUndo/kundo2

2012-07-02 Thread Jarosław Staniek
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105366/#review15315 --- kexi/plugins/tables/kexitabledesignerview.cpp

Re: Review Request: Port tables plugin to QUndo/kundo2

2012-06-30 Thread Adam Pigg
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105366/ --- (Updated June 30, 2012, 9:54 p.m.) Review request for Calligra and Jarosła

Re: Review Request: Port tables plugin to QUndo/kundo2

2012-06-29 Thread Jarosław Staniek
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105366/#review15259 --- Thanks. In case of such ports it may be good idea to test with

Re: Review Request: Port tables plugin to QUndo/kundo2

2012-06-29 Thread Adam Pigg
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105366/ --- (Updated June 29, 2012, 12:52 p.m.) Review request for Calligra and Jarosł