Re: Review Request: Optimize loading speed of tables

2011-12-15 Thread Marijn Kruisselbrink
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103408/#review8986 --- Ship it! Ship It! - Marijn Kruisselbrink On Dec. 15, 2011, 4

Re: Review Request: Optimize loading speed of tables

2011-12-14 Thread Thorsten Zachmann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103408/ --- (Updated Dec. 15, 2011, 4:23 a.m.) Review request for Calligra. Changes

Re: Review Request: Optimize loading speed of tables

2011-12-14 Thread Thorsten Zachmann
> On Dec. 15, 2011, 1:59 a.m., Marijn Kruisselbrink wrote: > > tables/Region.cpp, line 173 > > > > > > commented out code is probably a leftover from something else? That was for the next step so I can check how mu

Re: Review Request: Optimize loading speed of tables

2011-12-14 Thread Thorsten Zachmann
> On Dec. 14, 2011, 12:06 p.m., Jarosław Staniek wrote: > > tables/Formula.cpp, line 162 > > > > > > Can't we have Token::Plus == '+' as in flex+bison-generated parsers; > > then this could would become much simple

Re: Review Request: Optimize loading speed of tables

2011-12-14 Thread Marijn Kruisselbrink
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103408/#review8962 --- Over-all I like it, some small comments though tables/Formula.

Re: Review Request: Optimize loading speed of tables

2011-12-14 Thread Jarosław Staniek
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103408/#review8952 --- tables/Formula.cpp

Re: Review Request: Optimize loading speed of tables

2011-12-14 Thread Thorsten Zachmann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103408/ --- (Updated Dec. 14, 2011, 11:18 a.m.) Review request for Calligra. Descrip

Review Request: Optimize loading speed of tables

2011-12-14 Thread Thorsten Zachmann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103408/ --- Review request for Calligra. Description --- Optimize formula parsing