Re: Review Request: Moving anchor strategy into text shape

2011-01-27 Thread Pierre Stirnweiss
> > > > Anyway there will not be that much interaction between the layout and > loading. > So I guess we could make it into a separate text-layout library. But first > I > would like a usecase of someone not wanting the full blown layout after > having > loaded everything into a library that loads

Re: Review Request: Moving anchor strategy into text shape

2011-01-27 Thread C. Boemann
On Thursday 27 January 2011 11:49:40 Pierre Stirnweiss wrote: > > Well as i said it's going to be abstracted away, and we are creating a > > layout > > engine for ODF after all. Meaning that a lot of the layout is quite > > specified > > how should look. > > If all a user wants is layout of text,

Re: Review Request: Moving anchor strategy into text shape

2011-01-27 Thread Pierre Stirnweiss
> > Well as i said it's going to be abstracted away, and we are creating a > layout > engine for ODF after all. Meaning that a lot of the layout is quite > specified > how should look. If all a user wants is layout of text, then kotext is handly > a match anyway. And yes there might be a little ov

Re: Review Request: Moving anchor strategy into text shape

2011-01-27 Thread C. Boemann
On Thursday 27 January 2011 11:15:22 Pierre Stirnweiss wrote: > On Thu, Jan 27, 2011 at 10:51 AM, C. Boemann wrote: > > Well this is a step on the road and not the end result. So bear with me. > > > > But I've indeed changed my mind about who does the layout and drawing, > > and have come up with

Re: Review Request: Moving anchor strategy into text shape

2011-01-27 Thread Pierre Stirnweiss
On Thu, Jan 27, 2011 at 10:51 AM, C. Boemann wrote: > Well this is a step on the road and not the end result. So bear with me. > > But I've indeed changed my mind about who does the layout and drawing, and > have come up with an abstraction that will allow the kotext library to do > just > that.

Re: Review Request: Moving anchor strategy into text shape

2011-01-27 Thread C. Boemann
Well this is a step on the road and not the end result. So bear with me. But I've indeed changed my mind about who does the layout and drawing, and have come up with an abstraction that will allow the kotext library to do just that. Well totally controlled by the textshape. This abstraction will

Re: Review Request: Moving anchor strategy into text shape

2011-01-27 Thread Pierre Stirnweiss
Sorry to arrive after the battle, but I still would like to give an opinion on this one. I don't think this change is going in the right direction. It mixes responsibilities between kotext lib/textshape/application even more. I think we should have a clear separation of responsibilities: kotext li

Re: Review Request: Moving anchor strategy into text shape

2011-01-26 Thread Thorsten Zachmann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100442/#review1086 --- I just added some small comments mostly about the style. Would b

Re: Review Request: Moving anchor strategy into text shape

2011-01-26 Thread Casper Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100442/#review1084 --- Ship it! - Casper On Jan. 25, 2011, 2:04 p.m., Matus Hanzes w

Review Request: Moving anchor strategy into text shape

2011-01-25 Thread Matus Hanzes
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100442/ --- Review request for Calligra and Casper Boemann. Summary --- This patc