---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102679/#review6981
---
This review has been submitted with commit
b844d6f087f97fab2dc1
> On Oct. 1, 2011, 5:09 a.m., Thorsten Zachmann wrote:
> > Looks good. Please commit after fixing the pointed out.
> >
> > I'm not sure about the new classname KoShapeBasedDocumentBase. The
> > orrurence of two times Base somehow troubles me. How about renaming it to
> > KoShapeDocumentBase? T
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102679/#review6979
---
Ship it!
Looks good. Please commit after fixing the pointed out
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102679/
---
(Updated Sept. 29, 2011, 10:16 a.m.)
Review request for Calligra.
Change
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102679/
---
(Updated Sept. 29, 2011, 9:26 a.m.)
Review request for Calligra.
Changes
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102679/#review6760
---
Ship it!
- C.
On Sept. 23, 2011, 8:44 a.m., Boudewijn Rempt w
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102679/
---
(Updated Sept. 23, 2011, 8:44 a.m.)
Review request for Calligra.
Changes
> On Sept. 22, 2011, 8:08 p.m., C. Boemann wrote:
> > In general quite nice. A few remarks, and then i just assumed you moved the
> > commands with maybe a little rename but i din't exactly read all of them.
> > Please advice if i need to.
> >
> >
> > For the kotexteditor::paste i think we sh
ah the irc suggestion was on the specifics of a paste method, and not related
to architecture
have fun
On Friday 23 September 2011 10:10:13 Pierre Stirnweiss wrote:
> I didn't mean to make an assessement on the patch actually. I was answering
> to the IRC suggestion actually. I indeed personnaly
On Friday 23 September 2011 Sep, Pierre Stirnweiss wrote:
> I didn't mean to make an assessement on the patch actually. I was answering
> to the IRC suggestion actually. I indeed personnaly think that the textshape
> is not the place for the commands.
> However, we should also try to keep an open m
I didn't mean to make an assessement on the patch actually. I was answering
to the IRC suggestion actually. I indeed personnaly think that the textshape
is not the place for the commands.
However, we should also try to keep an open mind for the exercise at the
sprint. Otherwise we might format ours
Well yes but i thought we agreed on this. I mean, do you think this is not a
step in the right direction?
On Friday 23 September 2011 09:56:00 Pierre Stirnweiss wrote:
> I thought we had planned to discuss the kotext/textlayout/textshape
> architecture at the sprint.
>
> Pierre
>
> On Thu, Se
I thought we had planned to discuss the kotext/textlayout/textshape
architecture at the sprint.
Pierre
On Thu, Sep 22, 2011 at 10:08 PM, C. Boemann wrote:
>This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102679/
>
> In general quite nice. A f
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102679/#review6742
---
In general quite nice. A few remarks, and then i just assumed yo
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102679/
---
Review request for Calligra.
Summary
---
KoTextEditor is meant to be
15 matches
Mail list logo
