Re: Review Request: Make the epub filter handle math formulas

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107969/#review24405 --- This review has been submitted with commit e936399b17fc41b8c2b

Re: Review Request: Make the epub filter handle math formulas

> On Dec. 31, 2012, 9:42 p.m., mojtaba shahi wrote: > > I found something, I tested your patch and made an epub from your document > > sample (sqrt) and it doesn't look right for me. > > I unpacked the epub and tryed to open the .xhtml (chapter1.xhtml) with my > > browser and it got error. I ch

Re: Review Request: Make the epub filter handle math formulas

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107969/#review24354 --- I found something, I tested your patch and made an epub from yo

Re: Review Request: Make the epub filter handle math formulas

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107969/#review24321 --- filters/words/epub/OdtHtmlConverter.cpp

Re: Review Request: Make the epub filter handle math formulas

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107969/#review24315 --- Ship it! Ship It! - mojtaba shahi On Dec. 30, 2012, 4:44 a.

Re: Review Request: Make the epub filter handle math formulas

> On Dec. 28, 2012, 2:45 p.m., C. Boemann wrote: > > there is a few places where you have: > > > > if () > > { > > > > and one place where there is no {} after if > > > > other than that I've not looked yet - I assume you want moji to review > > Inge Wallin wrote: > The > > if (

Re: Review Request: Make the epub filter handle math formulas

> On Dec. 28, 2012, 2:45 p.m., C. Boemann wrote: > > there is a few places where you have: > > > > if () > > { > > > > and one place where there is no {} after if > > > > other than that I've not looked yet - I assume you want moji to review > > Inge Wallin wrote: > The > > if (

Re: Review Request: Make the epub filter handle math formulas

> On Dec. 28, 2012, 2:45 p.m., C. Boemann wrote: > > there is a few places where you have: > > > > if () > > { > > > > and one place where there is no {} after if > > > > other than that I've not looked yet - I assume you want moji to review > > Inge Wallin wrote: > The > > if (

Re: Review Request: Make the epub filter handle math formulas

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107969/ --- (Updated Dec. 30, 2012, 4:44 a.m.) Review request for Calligra. Changes

Re: Review Request: Make the epub filter handle math formulas

> On Dec. 28, 2012, 2:45 p.m., C. Boemann wrote: > > there is a few places where you have: > > > > if () > > { > > > > and one place where there is no {} after if > > > > other than that I've not looked yet - I assume you want moji to review The if () { construct is only used where the tes

Re: Review Request: Make the epub filter handle math formulas

> On Dec. 28, 2012, 9:11 p.m., Friedrich W. H. Kossebau wrote: > > Cannot really comment on the usecase, only nitpick on implementation level. > > Done that. > > > > All in all I see no reason to block this from entering master. But leaving > > decision to someone else. Forgot to say that som

Re: Review Request: Make the epub filter handle math formulas

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107969/#review24131 --- Cannot really comment on the usecase, only nitpick on implement

Re: Review Request: Make the epub filter handle math formulas

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107969/#review24105 --- there is a few places where you have: if () { and one place w

Re: Review Request: Make the epub filter handle math formulas

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107969/ --- (Updated Dec. 28, 2012, 2:48 a.m.) Review request for Calligra. Changes

Review Request: Make the epub filter handle math formulas

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107969/ --- Review request for Calligra. Description --- Diffs - filters/