Re: Review Request: Fix loading/saving clone layers

2011-10-20 Thread Dmitry Kazakov
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102896/#review7512 --- Ship it! Great work! =) - Dmitry Kazakov On Oct. 20, 2011, 4

Re: Review Request: Fix loading/saving clone layers

2011-10-20 Thread Torio Mlshi
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102896/ --- (Updated Oct. 20, 2011, 4:17 p.m.) Review request for Calligra and Boudewi

Re: Review Request: Fix loading/saving clone layers

2011-10-19 Thread Torio Mlshi
> On Oct. 16, 2011, 6:04 p.m., Dmitry Kazakov wrote: > > Hi! > > > > It's a really cool idea to use uuids here! I think the patch is very good, > > but i have one small concern. Is it possible to remove old code like > > copyFromName(), setCopyFromName() and findNodeByName()? Probably, map the

Re: Review Request: Fix loading/saving clone layers

2011-10-17 Thread Dmitry Kazakov
> On Oct. 16, 2011, 6:04 p.m., Dmitry Kazakov wrote: > > Hi! > > > > It's a really cool idea to use uuids here! I think the patch is very good, > > but i have one small concern. Is it possible to remove old code like > > copyFromName(), setCopyFromName() and findNodeByName()? Probably, map the

Re: Review Request: Fix loading/saving clone layers

2011-10-16 Thread Boudewijn Rempt
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102896/#review7420 --- Ship it! I agree with Dmitry -- looks good to me. Can you push

Re: Review Request: Fix loading/saving clone layers

2011-10-16 Thread Torio Mlshi
> On Oct. 16, 2011, 6:04 p.m., Dmitry Kazakov wrote: > > Hi! > > > > It's a really cool idea to use uuids here! I think the patch is very good, > > but i have one small concern. Is it possible to remove old code like > > copyFromName(), setCopyFromName() and findNodeByName()? Probably, map the

Re: Review Request: Fix loading/saving clone layers

2011-10-16 Thread Dmitry Kazakov
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102896/#review7400 --- Hi! It's a really cool idea to use uuids here! I think the patc

Re: Review Request: Fix loading/saving clone layers

2011-10-16 Thread Dmitry Kazakov
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102896/#review7401 --- Hi! It's a really cool idea to use uuids here! I think the patc

Re: Review Request: Fix loading/saving clone layers

2011-10-16 Thread Torio Mlshi
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102896/ --- (Updated Oct. 16, 2011, 4:59 p.m.) Review request for Calligra and Boudewi