Re: Review Request: Changing main.cpp to use KApplication in calligra active

2012-11-08 Thread Shantanu Tushar
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107244/#review21639 --- Ship it! Ship It! - Shantanu Tushar On Nov. 8, 2012, 1:26 p

Re: Review Request: Changing main.cpp to use KApplication in calligra active

2012-11-08 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107244/#review21640 --- This review has been submitted with commit 11ef47aa0f1083ee227

Re: Review Request: Changing main.cpp to use KApplication in calligra active

2012-11-08 Thread Sujith Haridasan
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107244/ --- (Updated Nov. 8, 2012, 1:26 p.m.) Review request for Calligra and Shantanu

Re: Review Request: Changing main.cpp to use KApplication in calligra active

2012-11-08 Thread Sujith Haridasan
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107244/ --- (Updated Nov. 8, 2012, 9:43 a.m.) Review request for Calligra and Shantanu

Re: Review Request: Changing main.cpp to use KApplication in calligra active

2012-11-07 Thread Jarosław Staniek
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107244/#review21587 --- active/main.cpp

Re: Review Request: Changing main.cpp to use KApplication in calligra active

2012-11-07 Thread Sujith Haridasan
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107244/ --- (Updated Nov. 7, 2012, 6:11 p.m.) Review request for Calligra and Shantanu

Re: Review Request: Changing main.cpp to use KApplication in calligra active

2012-11-07 Thread Sujith Haridasan
> On Nov. 7, 2012, 2:27 p.m., Boudewijn Rempt wrote: > > active/main.cpp, line 53 > > > > > > Doesn't this change break opening a file from an argument? Also -- why > > create the MainWindow on the heap now? It did

Re: Review Request: Changing main.cpp to use KApplication in calligra active

2012-11-07 Thread Jarosław Staniek
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107244/#review21557 --- active/main.cpp

Re: Review Request: Changing main.cpp to use KApplication in calligra active

2012-11-07 Thread Boudewijn Rempt
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107244/#review21555 --- active/main.cpp

Review Request: Changing main.cpp to use KApplication in calligra active

2012-11-07 Thread Sujith Haridasan
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107244/ --- Review request for Calligra and Shantanu Tushar. Description --- Movi