Re: Review Request: Add PDF support to KOConverter

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102837/#review7462 --- This review has been submitted with commit 6d71da0a3103eb3027e8

Re: Review Request: Add PDF support to KOConverter

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102837/#review7461 --- Ship it! good job! - Jarosław Staniek On Oct. 13, 2011, 11:0

Re: Review Request: Add PDF support to KOConverter

> On Oct. 14, 2011, 7:10 p.m., Sebastian Sauer wrote: > > Ship It! > > Sebastian Sauer wrote: > Or does anybody still see probs? i take it that's a no, then? ;) (yeah, i know, wait a week to resolve, but... ship it from one person should be enough, if my reading of the calligra rb policy'

Re: Review Request: Add PDF support to KOConverter

> On Oct. 14, 2011, 7:10 p.m., Sebastian Sauer wrote: > > Ship It! Or does anybody still see probs? - Sebastian --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102837/#review7345

Re: Review Request: Add PDF support to KOConverter

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102837/#review7345 --- Ship it! Ship It! - Sebastian Sauer On Oct. 13, 2011, 11:01

Re: Review Request: Add PDF support to KOConverter

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102837/ --- (Updated Oct. 13, 2011, 11:01 a.m.) Review request for Calligra. Changes

Re: Review Request: Add PDF support to KOConverter

> On Oct. 12, 2011, 7:33 p.m., Jan Hambrecht wrote: > > tools/converter/koconverter.cpp, lines 71-73 > > > > > > I think you should check for a null pointer before defererencing. Done and done - i actually did befor

Re: Review Request: Add PDF support to KOConverter

> On Oct. 12, 2011, 5:22 p.m., Sebastian Sauer wrote: > > tools/converter/koconverter.cpp, line 76 > > > > > > maybe don't silent fail and return KoFilter::OK in that case? So, > > something like > > > > st

Re: Review Request: Add PDF support to KOConverter

> On Oct. 12, 2011, 3:05 p.m., Jarosław Staniek wrote: > > tools/converter/koconverter.cpp, line 48 > > > > > > const for bool not needed (I know this was already there but this is > > opportunity to fix ;) Quite t

Re: Review Request: Add PDF support to KOConverter

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102837/#review7277 --- tools/converter/koconverter.cpp

Re: Review Request: Add PDF support to KOConverter

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102837/#review7272 --- tools/converter/koconverter.cpp

Re: Review Request: Add PDF support to KOConverter

> On Oct. 12, 2011, 4:40 p.m., Thorsten Zachmann wrote: > > tools/converter/koconverter.cpp, line 51 > > > > > > There should be no space after( and before ). This is also true for the > > rest of the patch > > Dan

Re: Review Request: Add PDF support to KOConverter

> On Oct. 12, 2011, 4:40 p.m., Thorsten Zachmann wrote: > > tools/converter/koconverter.cpp, line 51 > > > > > > There should be no space after( and before ). This is also true for the > > rest of the patch Normall

Re: Review Request: Add PDF support to KOConverter

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102837/#review7269 --- tools/converter/CMakeLists.txt

Re: Review Request: Add PDF support to KOConverter

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102837/#review7262 --- tools/converter/koconverter.cpp

Review Request: Add PDF support to KOConverter

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102837/ --- Review request for Calligra. Description --- As subject indicates. Us