Re: Review Request: Add svg support to the flake library

2011-08-24 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102315/#review5991 --- This review has been submitted with commit e72ec9cf9d64413117a2

Re: Review Request: Add svg support to the flake library

2011-08-24 Thread Thorsten Zachmann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102315/#review5990 --- Ship it! Looks good. Nice work. - Thorsten On Aug. 23, 2011,

Re: Review Request: Add svg support to the flake library

2011-08-23 Thread Jan Hambrecht
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102315/ --- (Updated Aug. 23, 2011, 7:07 p.m.) Review request for Calligra. Changes

Re: Review Request: Add svg support to the flake library

2011-08-21 Thread Jan Hambrecht
> On Aug. 21, 2011, 4:31 a.m., Thorsten Zachmann wrote: > > 1. There is a shape factory SvgShapeFactory which must be added to the > > shape registry to allow creating individual shapes from embedded svg > > content instead of using the VectorShape to display embedded svg content. > > The thin

Re: Review Request: Add svg support to the flake library

2011-08-21 Thread Jan Hambrecht
On Sunday 21 August 2011 16:13:13 Boudewijn Rempt wrote: > On Sunday 21 August 2011 Aug, Jan Hambrecht wrote: > > > Does the VectorShape load svg content? > > > > There are actually 2 shapes advertizing themselves as reading anything > > having a mimetype starting with image. That being the pictur

Re: Review Request: Add svg support to the flake library

2011-08-21 Thread Boudewijn Rempt
On Sunday 21 August 2011 Aug, Jan Hambrecht wrote: > > Does the VectorShape load svg content? > > There are actually 2 shapes advertizing themselves as reading anything having > a mimetype starting with image. That being the picture shape and the vector > shape. But neither of them is able to lo

Re: Review Request: Add svg support to the flake library

2011-08-21 Thread Jan Hambrecht
> On Aug. 21, 2011, 4:31 a.m., Thorsten Zachmann wrote: > > 1. There is a shape factory SvgShapeFactory which must be added to the > > shape registry to allow creating individual shapes from embedded svg > > content instead of using the VectorShape to display embedded svg content. > > The thin

Re: Review Request: Add svg support to the flake library

2011-08-20 Thread Thorsten Zachmann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102315/#review5866 --- 1. There is a shape factory SvgShapeFactory which must be added

Re: Review Request: Add svg support to the flake library

2011-08-20 Thread Jan Hambrecht
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102315/ --- (Updated Aug. 20, 2011, 11:05 a.m.) Review request for Calligra. Changes

Re: Review Request: Add svg support to the flake library

2011-08-13 Thread Jan Hambrecht
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102315/ --- (Updated Aug. 13, 2011, 4:53 p.m.) Review request for Calligra. Changes

Review Request: Add svg support to the flake library

2011-08-13 Thread Jan Hambrecht
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102315/ --- Review request for Calligra. Summary --- This patch adds support for