Re: Review Request: [GCI] Adding d-pointers to kexi/formeditor

2012-12-14 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107647/#review23486 --- This review has been submitted with commit 3de63476d3ce2b088cd

Re: Review Request: [GCI] Adding d-pointers to kexi/formeditor

2012-12-13 Thread Andrey Inishev
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107647/ --- (Updated Dec. 14, 2012, 7:40 a.m.) Review request for Calligra and Jarosła

Re: Review Request: [GCI] Adding d-pointers to kexi/formeditor

2012-12-13 Thread Jarosław Staniek
> On Dec. 13, 2012, 9:37 p.m., Jarosław Staniek wrote: > > kexi/formeditor/widgetfactory.h, line 355 > > > > > > move ALL these methods down to protected section > > Andrey Inishev wrote: > These methods alre

Re: Review Request: [GCI] Adding d-pointers to kexi/formeditor

2012-12-13 Thread Andrey Inishev
> On Dec. 13, 2012, 9:37 p.m., Jarosław Staniek wrote: > > kexi/formeditor/widgetfactory.h, line 355 > > > > > > move ALL these methods down to protected section These methods already at protected section. Or you

Re: Review Request: [GCI] Adding d-pointers to kexi/formeditor

2012-12-13 Thread Jarosław Staniek
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107647/#review23434 --- Almost ready! Please carefully fix the issues. kexi/formedito

Re: Review Request: [GCI] Adding d-pointers to kexi/formeditor

2012-12-13 Thread Andrey Inishev
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107647/ --- (Updated Dec. 13, 2012, 10:14 a.m.) Review request for Calligra and Jarosł

Re: Review Request: [GCI] Adding d-pointers to kexi/formeditor

2012-12-12 Thread Jarosław Staniek
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107647/#review23359 --- kexi/formeditor/widgetwithsubpropertiesinterface.cpp

Re: Review Request: [GCI] Adding d-pointers to kexi/formeditor

2012-12-12 Thread Andrey Inishev
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107647/ --- (Updated Dec. 12, 2012, 10:03 a.m.) Review request for Calligra and Jarosł

Re: Review Request: [GCI] Adding d-pointers to kexi/formeditor

2012-12-12 Thread Andrey Inishev
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107647/ --- (Updated Dec. 12, 2012, 8:37 a.m.) Review request for Calligra and Jarosła

Re: Review Request: [GCI] Adding d-pointers to kexi/formeditor

2012-12-12 Thread Jarosław Staniek
> On Dec. 10, 2012, 9 p.m., Jarosław Staniek wrote: > > kexi/formeditor/objecttree.cpp, line 149 > > > > > > change to const QString &set please fix this - Jarosław ---

Re: Review Request: [GCI] Adding d-pointers to kexi/formeditor

2012-12-11 Thread Andrey Inishev
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107647/ --- (Updated Dec. 12, 2012, 7:48 a.m.) Review request for Calligra and Jarosła

Re: Review Request: [GCI] Adding d-pointers to kexi/formeditor

2012-12-11 Thread Jarosław Staniek
> On Dec. 10, 2012, 9:23 p.m., Jarosław Staniek wrote: > > Afterwards please also fix build in kexi/plugins/forms/ and include the > > fixes in this review. > > Andrey Inishev wrote: > What do you mean? This (there may be more errors): Building CXX object kexi/plugins/forms/CMakeFiles/ke

Re: Review Request: [GCI] Adding d-pointers to kexi/formeditor

2012-12-11 Thread Andrey Inishev
> On Dec. 10, 2012, 9:23 p.m., Jarosław Staniek wrote: > > Afterwards please also fix build in kexi/plugins/forms/ and include the > > fixes in this review. What do you mean? - Andrey --- This is an automatically generated e-mail. To r

Re: Review Request: [GCI] Adding d-pointers to kexi/formeditor

2012-12-10 Thread Jarosław Staniek
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107647/#review23293 --- Afterwards please also fix build in kexi/plugins/forms/ and inc

Re: Review Request: [GCI] Adding d-pointers to kexi/formeditor

2012-12-10 Thread Jarosław Staniek
> On Dec. 9, 2012, 11:45 p.m., Jarosław Staniek wrote: > > kexi/formeditor/container.cpp, line 1043 > > > > > > please move '{' to new row not fixed (4 methods) > On Dec. 9, 2012, 11:45 p.m., Jarosław Staniek wr

Re: Review Request: [GCI] Adding d-pointers to kexi/formeditor

2012-12-10 Thread Jarosław Staniek
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107647/#review23287 --- Please *carefully* fix that: kexi/formeditor/container.cpp

Re: Review Request: [GCI] Adding d-pointers to kexi/formeditor

2012-12-10 Thread Andrey Inishev
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107647/ --- (Updated Dec. 10, 2012, 6:48 p.m.) Review request for Calligra and Jarosła

Review Request: [GCI] Adding d-pointers to kexi/formeditor

2012-12-09 Thread Andrey Inishev
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107647/ --- Review request for Calligra and Jarosław Staniek. Description --- Pat