Re: rng2cpp.cpp build fail with qt5.5

2015-05-29 Thread Treeve Jelbert
On Fri, 29 May 2015 01:03:41 +0200, Friedrich W. H. Kossebau wrote: Am Donnerstag, 28. Mai 2015, 22:44:04 schrieb Friedrich W. H. Kossebau: Okay. Now that I understand completely why it is needed, no objections from my side (in version which keeps the #if QT_VERSION < 0x040800 branches): #incl

Re: rng2cpp.cpp build fail with qt5.5

2015-05-28 Thread Friedrich W. H. Kossebau
Am Donnerstag, 28. Mai 2015, 22:44:04 schrieb Friedrich W. H. Kossebau: > Okay. Now that I understand completely why it is needed, no objections from > my side (in version which keeps the #if QT_VERSION < 0x040800 branches): > #include > #include > #include > +#include > +#include > > #

Re: rng2cpp.cpp build fail with qt5.5

2015-05-28 Thread Friedrich W. H. Kossebau
Am Donnerstag, 28. Mai 2015, 21:17:02 schrieb Treeve Jelbert: > On Thu, 28 May 2015 21:00:17 +0200 (CEST), Boudewijn Rempt wrote: > > On Thu, 28 May 2015, Friedrich W. H. Kossebau wrote: > >> Hi Treeve, > >> > >> thanks for reporting the error and working on a patch :) > >> > >> Am Donnerstag, 28

Re: rng2cpp.cpp build fail with qt5.5

2015-05-28 Thread Treeve Jelbert
On Thu, 28 May 2015 21:00:17 +0200 (CEST), Boudewijn Rempt wrote: On Thu, 28 May 2015, Friedrich W. H. Kossebau wrote: Hi Treeve, thanks for reporting the error and working on a patch :) Am Donnerstag, 28. Mai 2015, 13:31:29 schrieb Treeve Jelbert: thanks, the following diff fixes it diff --

Re: rng2cpp.cpp build fail with qt5.5

2015-05-28 Thread Friedrich W. H. Kossebau
Am Donnerstag, 28. Mai 2015, 21:00:17 schrieb Boudewijn Rempt: > On Thu, 28 May 2015, Friedrich W. H. Kossebau wrote: > > Hi Treeve, > > > > thanks for reporting the error and working on a patch :) > > > > Am Donnerstag, 28. Mai 2015, 13:31:29 schrieb Treeve Jelbert: > >> thanks, the following di

Re: rng2cpp.cpp build fail with qt5.5

2015-05-28 Thread Boudewijn Rempt
On Thu, 28 May 2015, Friedrich W. H. Kossebau wrote: Hi Treeve, thanks for reporting the error and working on a patch :) Am Donnerstag, 28. Mai 2015, 13:31:29 schrieb Treeve Jelbert: thanks, the following diff fixes it diff --git a/devtools/rng2cpp/rng2cpp.cpp b/devtools/rng2cpp/rng2cpp.cpp

Re: rng2cpp.cpp build fail with qt5.5

2015-05-28 Thread Friedrich W. H. Kossebau
Hi Treeve, thanks for reporting the error and working on a patch :) Am Donnerstag, 28. Mai 2015, 13:31:29 schrieb Treeve Jelbert: > thanks, the following diff fixes it > > diff --git a/devtools/rng2cpp/rng2cpp.cpp > b/devtools/rng2cpp/rng2cpp.cpp > index 3dc3214..de65ac4 100644 > --- a/devtools/

Re: rng2cpp.cpp build fail with qt5.5

2015-05-28 Thread Treeve Jelbert
On Thu, 28 May 2015 11:33:38 +0200 (CEST), Boudewijn Rempt wrote: I bet that's caused by this: #if QT_VERSION < 0x040800 # define assert(cond, what) (Q_ASSERT_X(cond, "", qPrintable(QString(what #else # define assert(cond, what) (Q_ASSERT_X(cond, "", qPrintable(what))) #endif thanks

Re: rng2cpp.cpp build fail with qt5.5

2015-05-28 Thread Boudewijn Rempt
I bet that's caused by this: #if QT_VERSION < 0x040800 # define assert(cond, what) (Q_ASSERT_X(cond, "", qPrintable(QString(what #else # define assert(cond, what) (Q_ASSERT_X(cond, "", qPrintable(what))) #endif Boud On Thu, 28 May 2015, Treeve Jelbert wrote: fails with qt-5.5.0 + gc