Re: Review Request 123587: Addition of user scripting API docs

2015-05-06 Thread Adam Pigg
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123587/ --- (Updated May 6, 2015, 6:41 p.m.) Status -- This change has been mark

Re: Review Request 123587: Addition of user scripting API docs

2015-05-06 Thread Adam Pigg
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123587/ --- (Updated May 6, 2015, 5:55 p.m.) Review request for Calligra and Jarosław

Re: Review Request 123587: Addition of user scripting API docs

2015-05-05 Thread Jarosław Staniek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123587/#review79925 --- libs/db/lookupfieldschema.h (line 145)

Re: Review Request 123587: Addition of user scripting API docs

2015-05-05 Thread Jarosław Staniek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123587/#review79924 --- libs/kotext/opendocument/KoTextWriter.cpp

Re: Review Request 123587: Addition of user scripting API docs

2015-05-05 Thread Jarosław Staniek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123587/#review79922 --- Ship it! GOOD! - Jarosław Staniek On May 5, 2015, 10:02 p.

Re: Review Request 123587: Addition of user scripting API docs

2015-05-05 Thread Adam Pigg
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123587/ --- (Updated May 5, 2015, 8:02 p.m.) Review request for Calligra and Jarosław

Re: Review Request 123587: Addition of user scripting API docs

2015-05-05 Thread Adam Pigg
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123587/ --- (Updated May 5, 2015, 6:30 p.m.) Review request for Calligra and Jarosław

Re: Review Request 123587: Addition of user scripting API docs

2015-05-05 Thread Adam Pigg
> On May 4, 2015, 8:36 p.m., Jarosław Staniek wrote: > > libs/koreport/renderer/scripting/krscriptconstants.h, line 58 > > > > > > Could you remind what was the reason to use capital letter for > > PageNumber? I

Re: Review Request 123587: Addition of user scripting API docs

2015-05-04 Thread Jarosław Staniek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123587/#review79866 --- libs/koreport/renderer/scripting/krscriptconstants.h (line 57

Re: Review Request 123587: Addition of user scripting API docs

2015-05-02 Thread Adam Pigg
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123587/ --- (Updated May 2, 2015, 9:12 p.m.) Review request for Calligra and Jarosław

Re: Review Request 123587: Addition of user scripting API docs

2015-05-02 Thread Adam Pigg
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123587/ --- (Updated May 2, 2015, 8:31 p.m.) Review request for Calligra and Jarosław

Re: Review Request 123587: Addition of user scripting API docs

2015-05-02 Thread Adam Pigg
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123587/ --- (Updated May 2, 2015, 3:05 p.m.) Review request for Calligra and Jarosław

Re: Review Request 123587: Addition of user scripting API docs

2015-05-01 Thread Adam Pigg
> On May 1, 2015, 9:48 p.m., Jarosław Staniek wrote: > > File Attachment: Mainpage - scripting.png > > > > > > Did we agree to use Report Element term or Item? cant remember source code uses Item. Maybe i could add a sentence stat

Re: Review Request 123587: Addition of user scripting API docs

2015-05-01 Thread Jarosław Staniek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123587/#review79766 --- File Attachment: Mainpage - scripting.png