Re: Review Request 114468: fix linking error on FillProcessingVisitorTest

2013-12-21 Thread Andrius da Costa Ribas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114468/ --- (Updated Dec. 21, 2013, 10:05 p.m.) Status -- This change has been di

Re: Review Request 114468: fix linking error on FillProcessingVisitorTest

2013-12-21 Thread Andrius da Costa Ribas
> On Dec. 17, 2013, 2:05 p.m., Dmitry Kazakov wrote: > > Oh.. I guess it is better to just remove defaulttools linking in the test, > > because it is not needed anymore :) It was just a copy-paste error I guess. > > Boudewijn Rempt wrote: > Yes, I think so too. I don't actually build the te

Re: Review Request 114468: fix linking error on FillProcessingVisitorTest

2013-12-19 Thread Boudewijn Rempt
> On Dec. 17, 2013, 2:05 p.m., Dmitry Kazakov wrote: > > Oh.. I guess it is better to just remove defaulttools linking in the test, > > because it is not needed anymore :) It was just a copy-paste error I guess. Yes, I think so too. I don't actually build the tests on Windows myself, btw. - B

Re: Review Request 114468: fix linking error on FillProcessingVisitorTest

2013-12-17 Thread Dmitry Kazakov
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114468/#review45865 --- Oh.. I guess it is better to just remove defaulttools linking i