Re: Review Request: add commands for chart operations

2012-08-20 Thread Thorsten Zachmann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106070/#review17788 --- Ship it! Looks good. Please ship - Thorsten Zachmann On Aug

Re: Review Request: add commands for chart operations

2012-08-20 Thread Brijesh Patel
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106070/ --- (Updated Aug. 20, 2012, 8:40 p.m.) Review request for Calligra, Inge Walli

Re: Review Request: add commands for chart operations

2012-08-19 Thread Inge Wallin
> On Aug. 19, 2012, 9:59 p.m., Inge Wallin wrote: > > Yes, I agree with Boemann. This is fine and ok to commit after you fix the > > one thing that I commented on below. Hmm, seems that review board removed my comment. It was that the coding standards demands spaces around operators. There are

Re: Review Request: add commands for chart operations

2012-08-19 Thread Inge Wallin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106070/#review17725 --- Ship it! Yes, I agree with Boemann. This is fine and ok to com

Re: Review Request: add commands for chart operations

2012-08-19 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106070/#review17722 --- >From my point of view it looks good to go. - C. Boemann On