Re: Review Request: User defined variables (2)

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103276/#review9637 --- Was this not already merged (but disabled). if so then please cl

Re: Review Request: User defined variables (2)

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103276/#review8721 --- Ship it! Looks good. I say ship it but it contains some new str

Re: Review Request: User defined variables (2)

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103276/ --- (Updated Dec. 5, 2011, 9:50 a.m.) Review request for Calligra and Thorsten

Re: Review Request: User defined variables (2)

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103276/#review8692 --- Hello Sebastian, the new patch seems to be the same as the old

Re: Review Request: User defined variables (2)

> On Nov. 28, 2011, 6:53 a.m., Thorsten Zachmann wrote: > > plugins/variables/UserVariable.h, lines 65-67 > > > > > > Is it possible to move the option widget into its own class. That makes > > it easier for applica

Re: Review Request: User defined variables (2)

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103276/ --- (Updated Dec. 1, 2011, 7:13 p.m.) Review request for Calligra and Thorsten

Re: Review Request: User defined variables (2)

> On Nov. 28, 2011, 6:53 a.m., Thorsten Zachmann wrote: > > libs/kotext/KoVariableManager.cpp, line 137 > > > > > > This should not use namedItemNS as this will iterate over all elements > > which can be very long

Re: Review Request: User defined variables (2)

> On Nov. 28, 2011, 6:53 a.m., Thorsten Zachmann wrote: > > Looks quite good. I have not yet tested it. It would be good if Mek could > > have a look at the calligra tables changes. I removed the Calligra Tables integration again. There is no useful way to add/remove/edit/display them atm anyw

Re: Review Request: User defined variables (2)

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103276/#review8555 --- Looks quite good. I have not yet tested it. It would be good if

Re: Review Request: User defined variables

> On Oct. 16, 2011, 4:56 p.m., Thorsten Zachmann wrote: > > Looking at the patch it does not support loading of the user defined > > variables for kopageapp. Also I think support for tables should be added. > > > > I think loading/saving should be done as the saving is done in kopageapp as > >

Re: Review Request: User defined variables

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102890/#review7393 --- Looking at the patch it does not support loading of the user def

Re: Review Request: User defined variables

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102890/#review7392 --- Looking at the patch it does not support loading of the user def

Re: Review Request: User defined variables

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102890/#review7389 --- Ship it! As far as I am concerned you can commit whenever you f

Re: Review Request: User defined variables

> On Oct. 16, 2011, 3:23 p.m., C. Boemann wrote: > > libs/kotext/KoVariableManager.h, line 59 > > > > > > woudn't enums be better then? Maybe. I made it a string so we don't lose unknown types but later changed the

Re: Review Request: User defined variables

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102890/#review7386 --- Looks very nice all in all. I see no objections to allowing it i

Re: Review Request: User defined variables

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102890/ --- (Updated Oct. 16, 2011, 9:47 a.m.) Review request for Calligra. Descript

Re: Review Request: User defined variables

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102890/ --- (Updated Oct. 16, 2011, 9:42 a.m.) Review request for Calligra. Descript