Re: Review Request: Implement triple button widget

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107530/#review24124 --- This review has been submitted with commit c83233855d3af2d0533

Re: Review Request: Implement triple button widget

> On Dec. 22, 2012, 6:14 p.m., C. Boemann wrote: > > given that I've just said ship-it to jaroslaw's request which builds on top > > of yours I think we can close your request, as refused. That said I want to > > say thanks for the great work you did on this. > > Jarosław Staniek wrote: >

Re: Review Request: Implement triple button widget

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107530/#review23874 --- This review has been submitted with commit 53c2670298f381f2bb1

Re: Review Request: Implement triple button widget

> On Dec. 22, 2012, 6:14 p.m., C. Boemann wrote: > > given that I've just said ship-it to jaroslaw's request which builds on top > > of yours I think we can close your request, as refused. That said I want to > > say thanks for the great work you did on this. BTW, Jean I am sorry for not commi

Re: Review Request: Implement triple button widget

> On Dec. 19, 2012, 10:29 p.m., Jarosław Staniek wrote: > > libs/widgets/KoGroupButton.cpp, line 41 > > > > > > Missing QToolButton(parent) call, what makes the widget invisible and > > uninitialized. > > Jean-Ni

Re: Review Request: Implement triple button widget

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107530/#review23856 --- given that I've just said ship-it to jaroslaw's request which b

Re: Review Request: Implement triple button widget

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107530/ --- (Updated Dec. 22, 2012, 4:07 p.m.) Review request for Calligra and C. Boem

Re: Review Request: Implement triple button widget

> On Dec. 20, 2012, 11:34 p.m., Jarosław Staniek wrote: > > For a test I added three buttons switching views in Kexi. > > > > - A mockup how that would look: > > http://kexi-project.org/pics/2.7/groupbutton/triple1-mockup.png > > > > Screenshots: > > - actual look using your newest revision 8:

Re: Review Request: Implement triple button widget

> On Dec. 19, 2012, 10:29 p.m., Jarosław Staniek wrote: > > libs/widgets/KoGroupButton.cpp, line 41 > > > > > > Missing QToolButton(parent) call, what makes the widget invisible and > > uninitialized. I don't und

Re: Review Request: Implement triple button widget

> On Dec. 20, 2012, 11:34 p.m., Jarosław Staniek wrote: > > For a test I added three buttons switching views in Kexi. > > > > - A mockup how that would look: > > http://kexi-project.org/pics/2.7/groupbutton/triple1-mockup.png > > > > Screenshots: > > - actual look using your newest revision 8:

Re: Review Request: Implement triple button widget

> On Dec. 20, 2012, 11:34 p.m., Jarosław Staniek wrote: > > For a test I added three buttons switching views in Kexi. > > > > - A mockup how that would look: > > http://kexi-project.org/pics/2.7/groupbutton/triple1-mockup.png > > > > Screenshots: > > - actual look using your newest revision 8:

Re: Review Request: Implement triple button widget

> On Dec. 20, 2012, 11:34 p.m., Jarosław Staniek wrote: > > For a test I added three buttons switching views in Kexi. > > > > - A mockup how that would look: > > http://kexi-project.org/pics/2.7/groupbutton/triple1-mockup.png > > > > Screenshots: > > - actual look using your newest revision 8:

Re: Review Request: Implement triple button widget

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107530/#review23784 --- For a test I added three buttons switching views in Kexi. - A

Re: Review Request: Implement triple button widget

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107530/#review23743 --- I've tested it with Kexi. Does its job quite nice already. Apar

Re: Review Request: Implement triple button widget

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107530/ --- (Updated Dec. 18, 2012, 2:46 p.m.) Review request for Calligra and C. Boem

Re: Review Request: Implement triple button widget

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107530/#review23663 --- libs/widgets/KoGroupButton.h

Re: Review Request: Implement triple button widget

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107530/ --- (Updated Dec. 18, 2012, 10:08 a.m.) Review request for Calligra and C. Boe

Re: Review Request: Implement triple button widget

> On Dec. 17, 2012, 2:34 p.m., Jean-Nicolas Artaud wrote: > > Hello Jeroslaw, > > Have you found some issues on this tripple button ? Maybe the name isn't > > okay cause you can group as many buttons as you need (so double, triple.. > > and multiple).. > > Thank you I am planning to test it,

Re: Review Request: Implement triple button widget

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107530/#review23609 --- Hello Jeroslaw, Have you found some issues on this tripple but

Re: Review Request: Implement triple button widget

> On Dec. 6, 2012, 11:01 p.m., C. Boemann wrote: > > Ok jaroslaw you take the review process from here - I'm in support of > > inclusion when you are satisfied with the code :) > > Jarosław Staniek wrote: > So I'll try to test the widget with various QStyles and also put it in > Kexi. This

Re: Review Request: Implement triple button widget

> On Dec. 6, 2012, 11:01 p.m., C. Boemann wrote: > > Ok jaroslaw you take the review process from here - I'm in support of > > inclusion when you are satisfied with the code :) So I'll try to test the widget with various QStyles and also put it in Kexi. This will take a few days I guess. Rela

Re: Review Request: Implement triple button widget

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107530/#review23130 --- Will you use the buttons also for the shown dialogs? libs/wid

Re: Review Request: Implement triple button widget

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107530/ --- (Updated Dec. 7, 2012, 7:37 a.m.) Review request for Calligra and C. Boema

Re: Review Request: Implement triple button widget

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107530/ --- (Updated Dec. 7, 2012, 7:34 a.m.) Review request for Calligra and C. Boema

Re: Review Request: Implement triple button widget

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107530/#review23104 --- Ok jaroslaw you take the review process from here - I'm in supp

Re: Review Request: Implement triple button widget

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107530/#review23093 --- I would use your group button in Kexi, please look at the blog

Re: Review Request: Implement triple button widget

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107530/ --- (Updated Dec. 6, 2012, 5:17 p.m.) Review request for Calligra and C. Boema

Re: Review Request: Implement triple button widget

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107530/ --- (Updated Dec. 4, 2012, 8:45 a.m.) Review request for Calligra and C. Boema

Re: Review Request: Implement triple button widget

> On Dec. 3, 2012, 9:49 a.m., C. Boemann wrote: > > I don't think we want this button to be used here. We should follow the > > lead of the text tool, where the buttons have become frameless. Also the > > design work done at Akademy determined that join and cap are rarely used > > and should b

Re: Review Request: Implement triple button widget

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107530/ --- (Updated Dec. 3, 2012, 10:55 a.m.) Review request for Calligra and C. Boem

Re: Review Request: Implement triple button widget

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107530/#review22928 --- I don't think we want this button to be used here. We should fo

Re: Review Request: Implement triple button widget

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107530/#review22925 --- When I try to view the diff I get an error message. Can you ple

Re: Review Request: Implement triple button widget

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107530/ --- (Updated Dec. 3, 2012, 12:41 a.m.) Review request for Calligra and C. Boem